Windows sbox: Warmup locales before sandbox lockdown (and tests)

Fixes for 1324523008 which was reverted. (Due to GetUserDefaultLocaleName being available on Vista and later)

Original description:
Add sbox tests related to warming up of locales.
Warm up locales in LowerToken() after RevertToSelf() as existing warmup was not working on Win 8.1 x64.
Remove existing warmup which was done outside of LowerToken().

BUG=464430
Committed: https://crrev.com/39fb5127a8a3a3f6216e48fd97ce9388c1e92c61
Cr-Commit-Position: refs/heads/master@{#363076}

[liamjm (20p), 2015-10-19 20:12:08]

Description was changed from

==========
PatchSet from issue 1324523008

BUG=
==========

to

==========
Fixes for 1324523008 which was reverted. (Due to GetUserDefaultLocaleName being
available on Vista and later)

Original description: 
Add sbox tests related to warming up of locales.
Warm up locales in LowerToken() after RevertToSelf() as existing warmup was not
working on Win 8.1 x64.
Remove existing warmup which was done outside of LowerToken().

BUG=464430
==========

[liamjm (20p), 2015-10-21 01:19:00]

liamjm@chromium.org changed reviewers:
+ isherman@chromium.org, jochen@chromium.org, jschuh@chromium.org,
wfh@chromium.org

[liamjm (20p), 2015-10-21 01:19:01]

Here is the fixes for issue 1324523008

[jochen (gone - plz use gerrit), 2015-10-21 13:28:18]

lgtm with comments

https://codereview.chromium.org/1419483002/diff/80001/sandbox/win/src/lpc_pol...
File sandbox/win/src/lpc_policy_test.cc (right):

https://codereview.chromium.org/1419483002/diff/80001/sandbox/win/src/lpc_pol...
sandbox/win/src/lpc_policy_test.cc:1: // Copyright (c) 2011 The Chromium
Authors. All rights reserved.
shouldn't this be 2015 and without the (c)?

[Will Harris, 2015-10-21 15:37:34]

https://codereview.chromium.org/1419483002/diff/40001/sandbox/win/src/lpc_pol...
File sandbox/win/src/lpc_policy_test.cc (right):

https://codereview.chromium.org/1419483002/diff/40001/sandbox/win/src/lpc_pol...
sandbox/win/src/lpc_policy_test.cc:35: ::GetUserDefaultLCID();
was there a reason why these tests were abbreviated in the latest patchset?

[liamjm (20p), 2015-10-21 20:11:03]

On 2015/10/21 15:37:34, Will Harris wrote:
>
https://codereview.chromium.org/1419483002/diff/40001/sandbox/win/src/lpc_pol...
> File sandbox/win/src/lpc_policy_test.cc (right):
> 
>
https://codereview.chromium.org/1419483002/diff/40001/sandbox/win/src/lpc_pol...
> sandbox/win/src/lpc_policy_test.cc:35: ::GetUserDefaultLCID();
> was there a reason why these tests were abbreviated in the latest patchset?

Yeah, big mixup with the patching. Sorry about that.

[liamjm (20p), 2015-10-21 20:11:14]

On 2015/10/21 13:28:18, jochen wrote:
> lgtm with comments
> 
>
https://codereview.chromium.org/1419483002/diff/80001/sandbox/win/src/lpc_pol...
> File sandbox/win/src/lpc_policy_test.cc (right):
> 
>
https://codereview.chromium.org/1419483002/diff/80001/sandbox/win/src/lpc_pol...
> sandbox/win/src/lpc_policy_test.cc:1: // Copyright (c) 2011 The Chromium
> Authors. All rights reserved.
> shouldn't this be 2015 and without the (c)?

Correct.
updated.

[Ilya Sherman, 2015-10-21 22:30:33]

histograms.xml lgtm

[Will Harris, 2015-11-07 01:19:26]

On 2015/10/21 22:30:33, Ilya Sherman wrote:
> histograms.xml lgtm

WarmupWindowsLocales in ppapi_thread.cc does a very similar thing to the new
code in target_services.cc - can they be combined in some way?

[Will Harris, 2015-11-10 20:50:20]

https://codereview.chromium.org/1419483002/diff/200001/sandbox/win/src/lpc_po...
File sandbox/win/src/lpc_policy_test.cc (right):

https://codereview.chromium.org/1419483002/diff/200001/sandbox/win/src/lpc_po...
sandbox/win/src/lpc_policy_test.cc:149: EXPECT_NE(size_t(0),
wcsnlen(locale_name, LOCALE_NAME_MAX_LENGTH));
use OU

[liamjm (20p), 2015-12-01 22:50:44]

On 2015/11/10 20:50:20, Will Harris wrote:
>
https://codereview.chromium.org/1419483002/diff/200001/sandbox/win/src/lpc_po...
> File sandbox/win/src/lpc_policy_test.cc (right):
> 
>
https://codereview.chromium.org/1419483002/diff/200001/sandbox/win/src/lpc_po...
> sandbox/win/src/lpc_policy_test.cc:149: EXPECT_NE(size_t(0),
> wcsnlen(locale_name, LOCALE_NAME_MAX_LENGTH));
> use OU

Done.

[Will Harris, 2015-12-03 06:06:40]

lgtm % nit

https://codereview.chromium.org/1419483002/diff/220001/sandbox/win/src/target...
File sandbox/win/src/target_services.cc (right):

https://codereview.chromium.org/1419483002/diff/220001/sandbox/win/src/target...
sandbox/win/src/target_services.cc:65: typedef int(WINAPI*
GetUserDefaultLocaleNameFunction)(LPWSTR lpLocaleName,
nit: could use typedef decltype e.g.

typedef decltype(GetUserDefaultLocaleName)* GetUserDefaultLocaleNameFunction;

[liamjm (20p), 2015-12-03 18:18:42]

https://codereview.chromium.org/1419483002/diff/220001/sandbox/win/src/target...
File sandbox/win/src/target_services.cc (right):

https://codereview.chromium.org/1419483002/diff/220001/sandbox/win/src/target...
sandbox/win/src/target_services.cc:65: typedef int(WINAPI*
GetUserDefaultLocaleNameFunction)(LPWSTR lpLocaleName,
On 2015/12/03 06:06:40, Will Harris wrote:
> nit: could use typedef decltype e.g.
> 
> typedef decltype(GetUserDefaultLocaleName)* GetUserDefaultLocaleNameFunction;

Done.

[liamjm (20p), 2015-12-03 18:19:14]

The CQ bit was checked by liamjm@chromium.org

[liamjm (20p), 2015-12-03 18:19:14]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org,
isherman@chromium.org, wfh@chromium.org
Link to the patchset: https://codereview.chromium.org/1419483002/#ps240001
(title: "use decltype in function ptr typedef of GetUserDefaultLocaleName")

[commit-bot: I haz the power, 2015-12-03 18:28:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1419483002/240001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1419483002/240001

[commit-bot: I haz the power, 2015-12-03 22:38:30]

Description was changed from

==========
Fixes for 1324523008 which was reverted. (Due to GetUserDefaultLocaleName being
available on Vista and later)

Original description: 
Add sbox tests related to warming up of locales.
Warm up locales in LowerToken() after RevertToSelf() as existing warmup was not
working on Win 8.1 x64.
Remove existing warmup which was done outside of LowerToken().

BUG=464430
==========

to

==========
Fixes for 1324523008 which was reverted. (Due to GetUserDefaultLocaleName being
available on Vista and later)

Original description: 
Add sbox tests related to warming up of locales.
Warm up locales in LowerToken() after RevertToSelf() as existing warmup was not
working on Win 8.1 x64.
Remove existing warmup which was done outside of LowerToken().

BUG=464430
==========

[commit-bot: I haz the power, 2015-12-03 22:38:31]

Committed patchset #13 (id:240001)

[commit-bot: I haz the power, 2015-12-03 22:39:35]

Description was changed from

==========
Fixes for 1324523008 which was reverted. (Due to GetUserDefaultLocaleName being
available on Vista and later)

Original description: 
Add sbox tests related to warming up of locales.
Warm up locales in LowerToken() after RevertToSelf() as existing warmup was not
working on Win 8.1 x64.
Remove existing warmup which was done outside of LowerToken().

BUG=464430
==========

to

==========
Fixes for 1324523008 which was reverted. (Due to GetUserDefaultLocaleName being
available on Vista and later)

Original description:
Add sbox tests related to warming up of locales.
Warm up locales in LowerToken() after RevertToSelf() as existing warmup was not
working on Win 8.1 x64.
Remove existing warmup which was done outside of LowerToken().

BUG=464430

Committed: https://crrev.com/39fb5127a8a3a3f6216e48fd97ce9388c1e92c61
Cr-Commit-Position: refs/heads/master@{#363076}
==========

[commit-bot: I haz the power, 2015-12-03 22:39:36]

Patchset 13 (id:??) landed as
https://crrev.com/39fb5127a8a3a3f6216e48fd97ce9388c1e92c61
Cr-Commit-Position: refs/heads/master@{#363076}