Add Wesley Wigham <t-weswig@microsoft.com> to AUTHORS

Add Wesley Wigham <t-weswig@microsoft.com>; to AUTHORS

Committed: https://crrev.com/32986d01b55fc391e69137091a09be04ead12582
Cr-Commit-Position: refs/heads/master@{#355867}

[wes, 2015-10-22 20:28:10]

wwigham@gmail.com changed reviewers:
+ paulirish@chromium.org, pfeldman@chromium.org

[paulirish, 2015-10-22 21:23:01]

Verified the CLA has been signed:
https://signcla.corp.google.com/search?q=t-weswig%40microsoft.com&cla=google


Pavel, does the codereview email (currently gmail) need to match what's in
AUTHORS?

[pfeldman, 2015-10-22 21:35:20]

On 2015/10/22 21:23:01, paulirish wrote:
> Verified the CLA has been signed:
> https://signcla.corp.google.com/search?q=t-weswig%40microsoft.com&cla=google
> 
> 
> Pavel, does the codereview email (currently gmail) need to match what's in
> AUTHORS?

It should be the same, yes.

[wes, 2015-10-22 21:57:08]

On 2015/10/22 21:35:20, pfeldman_slow wrote:
> On 2015/10/22 21:23:01, paulirish wrote:
> > Verified the CLA has been signed:
> > https://signcla.corp.google.com/search?q=t-weswig%40microsoft.com&cla=google
> > 
> > 
> > Pavel, does the codereview email (currently gmail) need to match what's in
> > AUTHORS?
> 
> It should be the same, yes.

Does it matter that that's a different email than the one used in the commits?

[paulirish, 2015-10-22 21:59:50]

> Does it matter that that's a different email than the one used in the commits?

We think that it'd be better if your codereview account was on your msft email. 
We expect a presubmit will reject the CL because of the mismatch.

[wes, 2015-10-22 22:02:04]

On 2015/10/22 21:57:08, wes wrote:
> On 2015/10/22 21:35:20, pfeldman_slow wrote:
> > On 2015/10/22 21:23:01, paulirish wrote:
> > > Verified the CLA has been signed:
> > >
https://signcla.corp.google.com/search?q=t-weswig%40microsoft.com&cla=google
> > > 
> > > 
> > > Pavel, does the codereview email (currently gmail) need to match what's in
> > > AUTHORS?
> > 
> > It should be the same, yes.
> 
> Does it matter that that's a different email than the one used in the commits?

Specifically, Rietveld picks out wwigham@gmail.com from my google account (my
primary email) for contact/display, but my commits (and the AUTHORS entry here)
are t-weswig@microsoft.com (an additional email on my google account).

[wes, 2015-10-22 22:33:08]

On 2015/10/22 22:02:04, wes wrote:
> On 2015/10/22 21:57:08, wes wrote:
> > On 2015/10/22 21:35:20, pfeldman_slow wrote:
> > > On 2015/10/22 21:23:01, paulirish wrote:
> > > > Verified the CLA has been signed:
> > > >
> https://signcla.corp.google.com/search?q=t-weswig%40microsoft.com&cla=google
> > > > 
> > > > 
> > > > Pavel, does the codereview email (currently gmail) need to match what's
in
> > > > AUTHORS?
> > > 
> > > It should be the same, yes.
> > 
> > Does it matter that that's a different email than the one used in the
commits?
> 
> Specifically, Rietveld picks out mailto:wwigham@gmail.com from my google
account (my
> primary email) for contact/display, but my commits (and the AUTHORS entry
here)
> are mailto:t-weswig@microsoft.com (an additional email on my google account).

(I can't actually log in to rietveld using my msft email - if I try, Rietveld
still picks the account's primary email)
I don't think it's a problem, though - the presubmit hooks for authorship pass
on this change (and any change based on it) - I'm pretty sure it looks at the
email on the commits, so this is definitely the right email to add to AUTHORS.

[paulirish, 2015-10-22 23:08:24]

Alright, well let's give it a go!

lgtm

[pfeldman, 2015-10-23 00:10:08]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2015-10-23 00:10:09]

lgtm

[commit-bot: I haz the power, 2015-10-23 00:10:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1419443004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1419443004/1

[commit-bot: I haz the power, 2015-10-23 00:24:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-23 00:24:55]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[wes, 2015-10-23 01:40:36]

On 2015/10/23 00:24:55, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

So, given that the try failed, it looks like the build server uses the email
from the Rietveld issue:
> ** Presubmit Warnings **
> wwigham@gmail.com is not in AUTHORS file. If you are a new contributor, please
visit
> http://www.chromium.org/developers/contributing-code and read the "Legal"
section
> If you are a chromite, verify the contributor signed the CLA.

While the local checks work against the email on the commits themselves.
Consistent.

I've no way to force Rietveld into using the msft email on my account (barring
maybe making it the primary email on my account?) so... maybe add both emails to
the AUTHORS file?

[paulirish, 2015-10-23 18:04:17]

> I've no way to force Rietveld into using the msft email on my account (barring
maybe making it the primary email on my account?) so... maybe add both emails to
the AUTHORS file?

Let's do that. We can migrate to using your microsoft email later.

[wes, 2015-10-23 18:42:50]

On 2015/10/23 18:04:17, paulirish wrote:
> > I've no way to force Rietveld into using the msft email on my account
(barring
> maybe making it the primary email on my account?) so... maybe add both emails
to
> the AUTHORS file?
> 
> Let's do that. We can migrate to using your microsoft email later.

Alright, I've added the second line to the CR.

[paulirish, 2015-10-23 20:06:13]

The CQ bit was checked by paulirish@chromium.org

[paulirish, 2015-10-23 20:06:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
paulirish@chromium.org, pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/1419443004/#ps20001
(title: "Add alternate email to AUTHORS")

[commit-bot: I haz the power, 2015-10-23 20:06:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1419443004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1419443004/20001

[commit-bot: I haz the power, 2015-10-23 20:18:29]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-10-23 20:19:23]

Patchset 2 (id:??) landed as
https://crrev.com/32986d01b55fc391e69137091a09be04ead12582
Cr-Commit-Position: refs/heads/master@{#355867}