Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 1419423004: dispatchTouchEvents(): mark local class as stack allocated. (Closed)

Created:
5 years, 1 month ago by sof
Modified:
5 years, 1 month ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

dispatchTouchEvents(): mark local class as stack allocated. The Blink GC plugin checks requires that the Oilpan heap references contained within the "changed touches" values are properly handled during GCs. They're all stack allocated, so mark the local class as STACK_ALLOCATED(). MSVC presents a problem in carrying that through (see comment), so lift out the local class from the dispatchTouchEvents() method at the same time. R=haraken BUG=553700 Committed: https://crrev.com/e0a03a4c0f85fa5a12180d9297c7622903b6b5a7 Cr-Commit-Position: refs/heads/master@{#358861}

Patch Set 1 #

Patch Set 2 : handle MSVC compilation failure #

Patch Set 3 : lift out local class instead #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -10 lines) Patch
M third_party/WebKit/Source/core/input/EventHandler.cpp View 1 2 3 chunks +25 lines, -10 lines 0 comments Download

Messages

Total messages: 19 (7 generated)
sof
please take a look.
5 years, 1 month ago (2015-11-10 07:20:44 UTC) #2
haraken
LGTM
5 years, 1 month ago (2015-11-10 07:24:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1419423004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1419423004/1
5 years, 1 month ago (2015-11-10 07:34:08 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/106482)
5 years, 1 month ago (2015-11-10 07:49:08 UTC) #8
sof
Hmm, this runs into MSVC's C4822 warning, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/132737/steps/compile%20%28with%20patch%29/logs/stdio which I don't think MSVC is in ...
5 years, 1 month ago (2015-11-10 08:39:27 UTC) #9
sof
On 2015/11/10 08:39:27, sof wrote: > Hmm, this runs into MSVC's C4822 warning, > > ...
5 years, 1 month ago (2015-11-10 11:01:05 UTC) #10
haraken
On 2015/11/10 11:01:05, sof wrote: > On 2015/11/10 08:39:27, sof wrote: > > Hmm, this ...
5 years, 1 month ago (2015-11-10 11:02:23 UTC) #11
sof
aw, the annotation isn't recognized by the plugin unless next to a deleted 'operator new'. ...
5 years, 1 month ago (2015-11-10 12:40:56 UTC) #12
sof
sending this along to unblock clang roll preparations.
5 years, 1 month ago (2015-11-10 18:35:45 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1419423004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1419423004/40001
5 years, 1 month ago (2015-11-10 18:36:57 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 1 month ago (2015-11-10 18:46:14 UTC) #18
commit-bot: I haz the power
5 years, 1 month ago (2015-11-10 18:47:11 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e0a03a4c0f85fa5a12180d9297c7622903b6b5a7
Cr-Commit-Position: refs/heads/master@{#358861}

Powered by Google App Engine
This is Rietveld 408576698