dispatchTouchEvents(): mark local class as stack allocated.

dispatchTouchEvents(): mark local class as stack allocated.

The Blink GC plugin checks requires that the Oilpan heap references contained
within the "changed touches" values are properly handled during GCs. They're
all stack allocated, so mark the local class as STACK_ALLOCATED(). MSVC
presents a problem in carrying that through (see comment), so lift out the
local class from the dispatchTouchEvents() method at the same time.

R=haraken
BUG=553700
Committed: https://crrev.com/e0a03a4c0f85fa5a12180d9297c7622903b6b5a7
Cr-Commit-Position: refs/heads/master@{#358861}

[sof, 2015-11-10 07:20:43]

sigbjornf@opera.com changed reviewers:
+ oilpan-reviews@chromium.org

[sof, 2015-11-10 07:20:44]

please take a look.

[haraken, 2015-11-10 07:24:39]

LGTM

[sof, 2015-11-10 07:33:45]

Description was changed from

==========
dispatchTouchEvents(): add STACK_ALLOCATED() annotation to local class.

R=
BUG=553700
==========

to

==========
dispatchTouchEvents(): add STACK_ALLOCATED() annotation to local class.

R=haraken
BUG=553700
==========

[sof, 2015-11-10 07:33:52]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2015-11-10 07:34:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1419423004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1419423004/1

[commit-bot: I haz the power, 2015-11-10 07:49:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-10 07:49:08]

Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[sof, 2015-11-10 08:39:27]

Hmm, this runs into MSVC's C4822 warning,


http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...

which I don't think MSVC is in the right to do.

[sof, 2015-11-10 11:01:05]

On 2015/11/10 08:39:27, sof wrote:
> Hmm, this runs into MSVC's C4822 warning,
> 
> 
>
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...
> 
> which I don't think MSVC is in the right to do.

ps#2 addresses this, acceptable? i.e., I really don't want to use
compiler-specific #if'ery in EventHandler.cpp, hence that approach.

[haraken, 2015-11-10 11:02:23]

On 2015/11/10 11:01:05, sof wrote:
> On 2015/11/10 08:39:27, sof wrote:
> > Hmm, this runs into MSVC's C4822 warning,
> > 
> > 
> >
>
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...
> > 
> > which I don't think MSVC is in the right to do.
> 
> ps#2 addresses this, acceptable? i.e., I really don't want to use
> compiler-specific #if'ery in EventHandler.cpp, hence that approach.

LGTM

[sof, 2015-11-10 12:40:56]

aw, the annotation isn't recognized by the plugin unless next to a deleted
'operator new'.

ps#3 simply works around this bugginess to local class handling by lifting out
the class decl. ptal (final one?)

[sof, 2015-11-10 13:25:36]

Description was changed from

==========
dispatchTouchEvents(): add STACK_ALLOCATED() annotation to local class.

R=haraken
BUG=553700
==========

to

==========
dispatchTouchEvents(): mark local class as stack allocated.

The Blink GC plugin checks requires that the Oilpan heap references contained
within the "changed touches" values are properly handled during GCs. They're
all stack allocated, so mark the local class as STACK_ALLOCATED(). MSVC
presents a problem in carrying that through (see comment), so lift out the
local class from the dispatchTouchEvents() method at the same time.

R=haraken
BUG=553700
==========

[sof, 2015-11-10 18:35:45]

sending this along to unblock clang roll preparations.

[sof, 2015-11-10 18:35:50]

The CQ bit was checked by sigbjornf@opera.com

[sof, 2015-11-10 18:35:50]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/1419423004/#ps40001
(title: "lift out local class instead")

[commit-bot: I haz the power, 2015-11-10 18:36:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1419423004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1419423004/40001

[commit-bot: I haz the power, 2015-11-10 18:46:14]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-11-10 18:47:11]

Patchset 3 (id:??) landed as
https://crrev.com/e0a03a4c0f85fa5a12180d9297c7622903b6b5a7
Cr-Commit-Position: refs/heads/master@{#358861}