Issue 14194003: Revert "Revert "Attempt to re-commit Dartdoc exports.""

Issue 14194003: Revert "Revert "Attempt to re-commit Dartdoc exports."" (Closed)

Created:
7 years, 8 months ago by Andrei Mouravski

Modified:
7 years, 8 months ago

Reviewers:
nweiz

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Revert "Revert "Attempt to re-commit Dartdoc exports."" This reverts commit 1340ca938883c2810fbc4e6d4ed4c52b68694faf. Committed: https://code.google.com/p/dart/source/detail?r=21320

Patch Set 1 #

Patch Set 2 : Maybe... #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1215 lines, -121 lines)			Patch
M	sdk/bin/dartdoc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/dartdoc/bin/dartdoc.dart	View	1	7 chunks	+42 lines, -39 lines	0 comments	Download
M	sdk/lib/_internal/dartdoc/lib/dartdoc.dart	View	1	23 chunks	+280 lines, -36 lines	0 comments	Download
M	sdk/lib/_internal/dartdoc/lib/src/dartdoc/utils.dart	View		3 chunks	+85 lines, -3 lines	0 comments	Download
A	sdk/lib/_internal/dartdoc/lib/src/export_map.dart	View		1 chunk	+342 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/dartdoc/pubspec.yaml	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	sdk/lib/_internal/dartdoc/test/dartdoc_test.dart	View		1 chunk	+0 lines, -36 lines	0 comments	Download
A	sdk/lib/_internal/dartdoc/test/export_map_test.dart	View		1 chunk	+400 lines, -0 lines	0 comments	Download
A	sdk/lib/_internal/dartdoc/test/utils_test.dart	View		1 chunk	+45 lines, -0 lines	0 comments	Download
M	utils/apidoc/apidoc.dart	View		8 chunks	+19 lines, -6 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Andrei Mouravski

Committed patchset #2 manually as r21320 (presubmit successful).

7 years, 8 months ago (2013-04-11 22:43:04 UTC) #3

ricow1

On 2013/04/11 22:43:04, Andrei Mouravski wrote: > Committed patchset #2 manually as r21320 (presubmit successful). ...

7 years, 8 months ago (2013-04-15 12:32:12 UTC) #4

Andrei Mouravski

On 2013/04/15 12:32:12, ricow1 wrote: > On 2013/04/11 22:43:04, Andrei Mouravski wrote: > > Committed ...

7 years, 8 months ago (2013-04-15 16:53:51 UTC) #5

Andrei Mouravski

7 years, 8 months ago (2013-04-15 16:53:52 UTC) #6

Message was sent while issue was closed.

On 2013/04/15 12:32:12, ricow1 wrote:
> On 2013/04/11 22:43:04, Andrei Mouravski wrote:
> > Committed patchset #2 manually as r21320 (presubmit successful).
> 
> Please use svn revisions in cl descriptions (getting the svn revision is as
easy
> as getting the git revision for a git developer - getting the svn revision by
> looking at the git revision is hard for a developer using svn)

Understood. It was out of haste that I committed that description, and I didn't
see the git hash in there.

I'll be more diligent in the future, or make myself a tool so I don't have to!

Expand Messages | Collapse Messages