Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Side by Side Diff: src/compiler/js-inlining-heuristic.h

Issue 1419373012: [turbofan] Run inlining within the regular reducer fixpoint. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Limit inlining depth. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/graph-reducer.cc ('k') | src/compiler/js-inlining-heuristic.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_COMPILER_JS_INLINING_HEURISTIC_H_ 5 #ifndef V8_COMPILER_JS_INLINING_HEURISTIC_H_
6 #define V8_COMPILER_JS_INLINING_HEURISTIC_H_ 6 #define V8_COMPILER_JS_INLINING_HEURISTIC_H_
7 7
8 #include "src/compiler/js-inlining.h" 8 #include "src/compiler/js-inlining.h"
9 9
10 namespace v8 { 10 namespace v8 {
11 namespace internal { 11 namespace internal {
12 namespace compiler { 12 namespace compiler {
13 13
14 class JSInliningHeuristic final : public AdvancedReducer { 14 class JSInliningHeuristic final : public AdvancedReducer {
15 public: 15 public:
16 enum Mode { kGeneralInlining, kRestrictedInlining, kStressInlining }; 16 enum Mode { kGeneralInlining, kRestrictedInlining, kStressInlining };
17 JSInliningHeuristic(Editor* editor, Mode mode, Zone* local_zone, 17 JSInliningHeuristic(Editor* editor, Mode mode, Zone* local_zone,
18 CompilationInfo* info, JSGraph* jsgraph) 18 CompilationInfo* info, JSGraph* jsgraph)
19 : AdvancedReducer(editor), 19 : AdvancedReducer(editor),
20 mode_(mode), 20 mode_(mode),
21 local_zone_(local_zone),
22 jsgraph_(jsgraph),
23 inliner_(editor, local_zone, info, jsgraph), 21 inliner_(editor, local_zone, info, jsgraph),
24 candidates_(local_zone), 22 candidates_(local_zone),
23 seen_(local_zone),
25 info_(info) {} 24 info_(info) {}
26 25
27 Reduction Reduce(Node* node) final; 26 Reduction Reduce(Node* node) final;
28 27
29 // Processes the list of candidates gathered while the reducer was running, 28 // Processes the list of candidates gathered while the reducer was running,
30 // and inlines call sites that the heuristic determines to be important. 29 // and inlines call sites that the heuristic determines to be important.
31 void ProcessCandidates(); 30 void Finalize() final;
32 31
33 private: 32 private:
34 struct Candidate { 33 struct Candidate {
35 Handle<JSFunction> function; // The call target being inlined. 34 Handle<JSFunction> function; // The call target being inlined.
36 Node* node; // The call site at which to inline. 35 Node* node; // The call site at which to inline.
37 int calls; // Number of times the call site was hit. 36 int calls; // Number of times the call site was hit.
38 }; 37 };
39 38
40 // Comparator for candidates. 39 // Comparator for candidates.
41 struct CandidateCompare { 40 struct CandidateCompare {
42 bool operator()(const Candidate& left, const Candidate& right) const; 41 bool operator()(const Candidate& left, const Candidate& right) const;
43 }; 42 };
44 43
45 // Candidates are kept in a sorted set of unique candidates. 44 // Candidates are kept in a sorted set of unique candidates.
46 typedef ZoneSet<Candidate, CandidateCompare> Candidates; 45 typedef ZoneSet<Candidate, CandidateCompare> Candidates;
47 46
48 // Dumps candidates to console. 47 // Dumps candidates to console.
49 void PrintCandidates(); 48 void PrintCandidates();
50 49
51 Mode const mode_; 50 Mode const mode_;
52 Zone* local_zone_;
53 JSGraph* jsgraph_;
54 JSInliner inliner_; 51 JSInliner inliner_;
55 Candidates candidates_; 52 Candidates candidates_;
53 ZoneSet<NodeId> seen_;
56 CompilationInfo* info_; 54 CompilationInfo* info_;
55 int cumulative_count_ = 0;
57 }; 56 };
58 57
59 } // namespace compiler 58 } // namespace compiler
60 } // namespace internal 59 } // namespace internal
61 } // namespace v8 60 } // namespace v8
62 61
63 #endif // V8_COMPILER_JS_INLINING_HEURISTIC_H_ 62 #endif // V8_COMPILER_JS_INLINING_HEURISTIC_H_
OLDNEW
« no previous file with comments | « src/compiler/graph-reducer.cc ('k') | src/compiler/js-inlining-heuristic.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698