Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1707)

Issue 1419373012: [turbofan] Run inlining within the regular reducer fixpoint. (Closed)

Created:
5 years, 1 month ago by Benedikt Meurer
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Run inlining within the regular reducer fixpoint. Introduce Reducer::Finalize, which get's called by the GraphReducer once all reductions are done, and use this to implement full inlining as part of the regular reducer fixpoint. R=jarin@chromium.org BUG=v8:4493 LOG=n Committed: https://crrev.com/9e9d1cb373bbba8e973e5a20ba3bbea488710148 Cr-Commit-Position: refs/heads/master@{#31875}

Patch Set 1 #

Patch Set 2 : REBASE #

Patch Set 3 : Limit inlining depth. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -22 lines) Patch
M src/compiler/graph-reducer.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/graph-reducer.cc View 2 chunks +8 lines, -1 line 0 comments Download
M src/compiler/js-inlining-heuristic.h View 2 chunks +4 lines, -5 lines 0 comments Download
M src/compiler/js-inlining-heuristic.cc View 1 2 4 chunks +19 lines, -15 lines 0 comments Download
M src/compiler/pipeline.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 16 (7 generated)
Benedikt Meurer
5 years, 1 month ago (2015-11-06 07:23:08 UTC) #1
Benedikt Meurer
Hey Jaro, Here's the change to run full transitive inlining as part of the GraphReducer ...
5 years, 1 month ago (2015-11-06 07:24:49 UTC) #2
Jarin
lgtm. I am not too happy about introducing this one-purpose method into the graph reducer, ...
5 years, 1 month ago (2015-11-06 07:38:33 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1419373012/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1419373012/1
5 years, 1 month ago (2015-11-06 07:44:15 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel/builds/11480)
5 years, 1 month ago (2015-11-06 07:55:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1419373012/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1419373012/40001
5 years, 1 month ago (2015-11-09 10:39:47 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1419373012/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1419373012/40001
5 years, 1 month ago (2015-11-09 10:47:38 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 1 month ago (2015-11-09 10:54:46 UTC) #15
commit-bot: I haz the power
5 years, 1 month ago (2015-11-09 10:55:08 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/9e9d1cb373bbba8e973e5a20ba3bbea488710148
Cr-Commit-Position: refs/heads/master@{#31875}

Powered by Google App Engine
This is Rietveld 408576698