Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: lib/src/linter.dart

Issue 1419373009: Lint to prefer x.isNotEmpty vs. !x.isEmpty (#143). (Closed) Base URL: https://github.com/dart-lang/linter.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/ast.dart ('k') | lib/src/rules.dart » ('j') | lib/src/rules/prefer_is_not_empty.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/linter.dart
diff --git a/lib/src/linter.dart b/lib/src/linter.dart
index 68b40f767840fd2afbb570b4ce8d4fcb2f354b0b..a7c0a57d2f33d129e3773e1084b1fcae083d0d82 100644
--- a/lib/src/linter.dart
+++ b/lib/src/linter.dart
@@ -98,7 +98,7 @@ class DartLinter implements AnalysisErrorListener {
} on Exception catch (e) {
reporter.exception(new LinterException(e.toString()));
}
- if (rule._locationInfo != null && !rule._locationInfo.isEmpty) {
+ if (rule._locationInfo != null && rule._locationInfo.isNotEmpty) {
results.addAll(rule._locationInfo);
rule._locationInfo.clear();
}
@@ -399,7 +399,7 @@ class SourceLinter implements DartLinter, AnalysisErrorListener {
} on Exception catch (e) {
reporter.exception(new LinterException(e.toString()));
}
- if (rule._locationInfo != null && !rule._locationInfo.isEmpty) {
+ if (rule._locationInfo != null && rule._locationInfo.isNotEmpty) {
results.addAll(rule._locationInfo);
rule._locationInfo.clear();
}
« no previous file with comments | « lib/src/ast.dart ('k') | lib/src/rules.dart » ('j') | lib/src/rules/prefer_is_not_empty.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698