Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Unified Diff: test/unittests/compiler/node-test-utils.cc

Issue 1419373007: [Interpreter] Adds implementation of bytecode graph builder for LoadICSloppy/Strict (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Modified bytecode-graph-builder-unittest to build bytecode array instead of generating it. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/unittests/compiler/node-test-utils.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/unittests/compiler/node-test-utils.cc
diff --git a/test/unittests/compiler/node-test-utils.cc b/test/unittests/compiler/node-test-utils.cc
index bfb9c06960c0424db611e33a32217dbd96882af4..ea34bd97d69e07735c34010ad44f0150673b3875 100644
--- a/test/unittests/compiler/node-test-utils.cc
+++ b/test/unittests/compiler/node-test-utils.cc
@@ -1404,6 +1404,7 @@ class IsUnopMatcher final : public NodeMatcher {
const Matcher<Node*> input_matcher_;
};
+
class IsParameterMatcher final : public NodeMatcher {
public:
explicit IsParameterMatcher(const Matcher<int>& index_matcher)
@@ -1425,6 +1426,60 @@ class IsParameterMatcher final : public NodeMatcher {
const Matcher<int> index_matcher_;
};
+
+// TODO(mythria): Check if we can use the same matcher for Load and Store
+class IsJSLoadNamedMatcher final : public NodeMatcher {
+ public:
+ IsJSLoadNamedMatcher(const Matcher<Handle<Name>>& name_matcher,
+ const Matcher<Node*>& object_value_matcher,
+ const Matcher<Node*>& feedback_vector_matcher,
+ const Matcher<Node*>& effect_matcher,
+ const Matcher<Node*>& control_matcher)
+ : NodeMatcher(IrOpcode::kJSLoadNamed),
+ name_matcher_(name_matcher),
+ object_value_matcher_(object_value_matcher),
+ feedback_vector_matcher_(feedback_vector_matcher),
+ effect_matcher_(effect_matcher),
+ control_matcher_(control_matcher) {}
+
+ void DescribeTo(std::ostream* os) const final {
+ NodeMatcher::DescribeTo(os);
+ *os << " whose object (";
+ object_value_matcher_.DescribeTo(os);
+ *os << "), name (";
+ name_matcher_.DescribeTo(os);
+ *os << "), feedback vector (";
+ feedback_vector_matcher_.DescribeTo(os);
+ *os << "), effect (";
+ effect_matcher_.DescribeTo(os);
+ *os << "), and control (";
+ control_matcher_.DescribeTo(os);
+ *os << ")";
+ }
+
+ bool MatchAndExplain(Node* node, MatchResultListener* listener) const final {
+ return (NodeMatcher::MatchAndExplain(node, listener) &&
+ PrintMatchAndExplain(OpParameter<const NamedAccess>(node).name(),
+ "Name", name_matcher_, listener) &&
+ PrintMatchAndExplain(NodeProperties::GetValueInput(node, 0),
+ "object", object_value_matcher_, listener) &&
+ PrintMatchAndExplain(NodeProperties::GetValueInput(node, 1),
+ "feedback vector", feedback_vector_matcher_,
+ listener) &&
+ PrintMatchAndExplain(NodeProperties::GetEffectInput(node), "effect",
+ effect_matcher_, listener) &&
+ PrintMatchAndExplain(NodeProperties::GetControlInput(node),
+ "control", control_matcher_, listener));
+ }
+
+ private:
+ const Matcher<Handle<Name>> name_matcher_;
+ const Matcher<Node*> object_value_matcher_;
+ const Matcher<Node*> feedback_vector_matcher_;
+ const Matcher<Node*> effect_matcher_;
+ const Matcher<Node*> control_matcher_;
+};
+
} // namespace
@@ -1998,6 +2053,17 @@ Matcher<Node*> IsLoadFramePointer() {
}
+Matcher<Node*> IsJSLoadNamed(const Handle<Name> name,
+ const Matcher<Node*>& object_value_matcher,
+ const Matcher<Node*>& feedback_vector_matcher,
+ const Matcher<Node*>& effect_matcher,
+ const Matcher<Node*>& control_matcher) {
+ return MakeMatcher(new IsJSLoadNamedMatcher(name, object_value_matcher,
+ feedback_vector_matcher,
+ effect_matcher, control_matcher));
+}
+
+
#define IS_BINOP_MATCHER(Name) \
Matcher<Node*> Is##Name(const Matcher<Node*>& lhs_matcher, \
const Matcher<Node*>& rhs_matcher) { \
« no previous file with comments | « test/unittests/compiler/node-test-utils.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698