[Interpreter] Adds implementation of bytecode graph builder for LoadICSloppy/Strict

src/compiler/pipeline.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/compiler/pipeline.h"
 
 #include <fstream>  // NOLINT(readability/streams)
 #include <sstream>
 
 #include "src/base/adapters.h"
@@ skipping 1043 matching lines @@
     OFStream os(stdout);
     os << "---------------------------------------------------\n"
        << "Begin compiling method " << info()->GetDebugName().get()
        << " using Turbofan" << std::endl;
     TurboCfgFile tcf(isolate());
     tcf << AsC1VCompilation(info());
   }
 
   data.source_positions()->AddDecorator();
 
-  if (FLAG_loop_assignment_analysis) {
+  if (FLAG_loop_assignment_analysis &&
+      !data.info()->shared_info()->HasBytecodeArray()) {

[mythria, 2015/11/04 12:19:14]

If this phase is required, I think we have to add a similar one from bytecode.
For now I just disabled it, when we are building the graph from bytecode array.
I did not check where LoopAssignmentAnalsysis is used. This analysis crashes if
we enable it when we are building it from bytecode. I think it is because it
expects a AStGraph.

[rmcilroy, 2015/11/04 14:27:37]

Could you dig into this a bit more and figure out what it needs - it is probably
just that we aren't doing something we need to do in BytecodeGraphTester.

     Run<LoopAssignmentAnalysisPhase>();
   }
 
   Run<GraphBuilderPhase>();
   if (data.compilation_failed()) return Handle<Code>::null();
   RunPrintAndVerify("Initial untyped", true);
 
   // Perform OSR deconstruction.
   if (info()->is_osr()) {
     Run<OsrDeconstructionPhase>();
@@ skipping 344 matching lines @@
     tcf << AsC1VRegisterAllocationData("CodeGen",
                                        data->register_allocation_data());
   }
 
   data->DeleteRegisterAllocationZone();
 }
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8