Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: DEPS

Issue 1419373005: Make checkdeps --resolve-dotdot succeed. (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master
Patch Set: add comments, more explicit disallows Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | core/include/fpdfapi/fpdf_render.h » ('j') | core/include/fpdfapi/fpdf_render.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: DEPS
diff --git a/DEPS b/DEPS
index 56d303c6265a9e6f44c4083aa701f4adf049f458..bd4912b4ef72e671e548ba32a9ca61fa79448c6f 100644
--- a/DEPS
+++ b/DEPS
@@ -34,6 +34,8 @@ deps_os = {
}
include_rules = [
+ # Basic stuff that everyone can use.
Tom Sepez 2015/11/04 18:50:56 Nope. core/ can't include public. All API access
Lei Zhang 2015/11/04 19:30:54 But there's code that violates this. Want me to fi
+ '+public',
'+testing',
'+third_party/base',
]
« no previous file with comments | « no previous file | core/include/fpdfapi/fpdf_render.h » ('j') | core/include/fpdfapi/fpdf_render.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698