Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1419373002: Use size_t for loop counter to avoid sign comparison warning (Closed)

Created:
5 years, 2 months ago by Petr Hosek
Modified:
5 years, 2 months ago
Reviewers:
Mark Seaborn
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/src/native_client.git@master
Target Ref:
refs/heads/master
Project:
nacl
Visibility:
Public.

Description

Use size_t for loop counter to avoid sign comparison warning BUG=462791 TEST= trybots Committed: https://chromium.googlesource.com/native_client/src/native_client/+/4ebe88579e6f6d28108c8df171f7e55b1d004bdd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/nonsfi/linux/irt_signal_handling.c View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
Petr Hosek
5 years, 2 months ago (2015-10-24 22:09:38 UTC) #3
Mark Seaborn
LGTM. Can you set BUG= to the GN-build issue, please?
5 years, 2 months ago (2015-10-24 22:11:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1419373002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1419373002/1
5 years, 2 months ago (2015-10-25 01:34:57 UTC) #7
commit-bot: I haz the power
5 years, 2 months ago (2015-10-25 01:36:04 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/native_client/src/native_client/+/4ebe88579...

Powered by Google App Engine
This is Rietveld 408576698