Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 1419363004: Always show distillation option in print preview (Closed)

Created:
5 years, 1 month ago by wychen
Modified:
5 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Always show distillation option in print preview The accuracy of distillability test is enough for prompting reader mode, but not for print preview. The user experience would be better if the user can override whether to distill. BUG=490809 Committed: https://crrev.com/89a9e430bdca57cf6543d431e001b0902abd29f1 Cr-Commit-Position: refs/heads/master@{#357476}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -16 lines) Patch
M chrome/browser/ui/webui/print_preview/print_preview_handler.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_handler.cc View 2 chunks +1 line, -11 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
wychen
PTAL
5 years, 1 month ago (2015-11-01 19:32:41 UTC) #4
arjunpatel
There might be overlap between this and and an existing CL https://codereview.chromium.org/1419063002. PTAL
5 years, 1 month ago (2015-11-02 22:09:35 UTC) #5
wychen
On 2015/11/02 22:09:35, arjunpatel wrote: > There might be overlap between this and and an ...
5 years, 1 month ago (2015-11-02 23:01:42 UTC) #6
wychen
On 2015/11/02 23:01:42, wychen wrote: > On 2015/11/02 22:09:35, arjunpatel wrote: > > There might ...
5 years, 1 month ago (2015-11-02 23:19:26 UTC) #7
Vitaly Buka (NO REVIEWS)
lgtm
5 years, 1 month ago (2015-11-02 23:31:11 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1419363004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1419363004/1
5 years, 1 month ago (2015-11-02 23:33:55 UTC) #11
wychen
On 2015/11/02 23:31:11, Vitaly Buka wrote: > lgtm Thanks for your prompt reply!
5 years, 1 month ago (2015-11-02 23:58:07 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-03 00:14:38 UTC) #13
commit-bot: I haz the power
5 years, 1 month ago (2015-11-03 00:15:33 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/89a9e430bdca57cf6543d431e001b0902abd29f1
Cr-Commit-Position: refs/heads/master@{#357476}

Powered by Google App Engine
This is Rietveld 408576698