Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issue 1419333005: Add `mojo_run --free-ports` to run servers on system-allocated ports. (Closed)

Created:
5 years, 1 month ago by ppi
Modified:
5 years, 1 month ago
Reviewers:
qsr
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add `mojo_run --free-ports` to run servers on system-allocated ports. This makes mojo devtools use system-allocated ports for all dev servers that normally are run on fixed ports to facilitate caching (ie. dev servers spawned for local --origin, --map-origin and --map-url). Note that this does not affect dev servers with explicitly assigned fixed ports in a mojoconfig file. Fixes #477. R=qsr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/6f424d79b6c6a87827fcd5a119d7c87c96476bc2

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address Ben's comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -8 lines) Patch
M mojo/devtools/common/devtoolslib/shell_arguments.py View 1 5 chunks +16 lines, -7 lines 0 comments Download
M mojo/devtools/common/devtoolslib/shell_config.py View 4 chunks +9 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
ppi
Hi Ben, ptal.
5 years, 1 month ago (2015-10-29 17:29:57 UTC) #2
qsr
LGTM with nits. https://codereview.chromium.org/1419333005/diff/1/mojo/devtools/common/devtoolslib/shell_arguments.py File mojo/devtools/common/devtoolslib/shell_arguments.py (right): https://codereview.chromium.org/1419333005/diff/1/mojo/devtools/common/devtoolslib/shell_arguments.py#newcode81 mojo/devtools/common/devtoolslib/shell_arguments.py:81: <origin>=<url-or-local-path>. Can you comment on free_ports ...
5 years, 1 month ago (2015-11-02 10:53:16 UTC) #3
ppi
https://codereview.chromium.org/1419333005/diff/1/mojo/devtools/common/devtoolslib/shell_arguments.py File mojo/devtools/common/devtoolslib/shell_arguments.py (right): https://codereview.chromium.org/1419333005/diff/1/mojo/devtools/common/devtoolslib/shell_arguments.py#newcode81 mojo/devtools/common/devtoolslib/shell_arguments.py:81: <origin>=<url-or-local-path>. On 2015/11/02 10:53:16, qsr wrote: > Can you ...
5 years, 1 month ago (2015-11-02 13:04:18 UTC) #4
ppi
5 years, 1 month ago (2015-11-02 13:14:08 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
6f424d79b6c6a87827fcd5a119d7c87c96476bc2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698