third_party/WebKit/Source/core/inspector/v8/InspectorWrapper.cpp - Issue 1419313003: Track the script state a listener was created in

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/v8/InspectorWrapper.cpp

Issue 1419313003: Track the script state a listener was created in (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/inspector/v8/InspectorWrapper.cpp

diff --git a/third_party/WebKit/Source/core/inspector/v8/InspectorWrapper.cpp b/third_party/WebKit/Source/core/inspector/v8/InspectorWrapper.cpp

index fe2e2bb2114d6411c3a2254b8da7e052d8fdea07..1cab1b3dab31af52a0e36d04b999d05b70c430cc 100644

--- a/third_party/WebKit/Source/core/inspector/v8/InspectorWrapper.cpp

+++ b/third_party/WebKit/Source/core/inspector/v8/InspectorWrapper.cpp

@@ -54,7 +54,7 @@ void* InspectorWrapperBase::unwrap(v8::Local<v8::Context> context, v8::Local<v8:

{

ASSERT(context != v8::Debug::GetDebugContext());

v8::Isolate* isolate = context->GetIsolate();

- v8::Local<v8::Value> value = V8HiddenValue::getHiddenValue(isolate, object, v8InternalizedString(isolate, name));

+ v8::Local<v8::Value> value = V8HiddenValue::getHiddenValue(ScriptState::from(context), object, v8InternalizedString(isolate, name));

if (value.IsEmpty())

return nullptr;

if (!value->IsExternal())