third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp - Issue 1419313003: Track the script state a listener was created in

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp

Issue 1419313003: Track the script state a listener was created in (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp b/third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp

index 5cef9ae17ea0f16e8d04ce08bb6d7a5e040d93e9..6ecd597899d6437f79cc2105f7a64e267e80505e 100644

--- a/third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp

@@ -426,7 +426,7 @@ void WindowProxy::updateDocumentProperty()

// We also stash a reference to the document on the inner global object so that

// LocalDOMWindow objects we obtain from JavaScript references are guaranteed to have

// live Document objects.

- V8HiddenValue::setHiddenValue(m_isolate, toInnerGlobalObject(context), V8HiddenValue::document(m_isolate), documentWrapper);

+ V8HiddenValue::setHiddenValue(m_scriptState.get(), toInnerGlobalObject(context), V8HiddenValue::document(m_isolate), documentWrapper);

}

void WindowProxy::updateActivityLogger()