third_party/WebKit/Source/bindings/core/v8/V8LazyEventListener.cpp - Issue 1419313003: Track the script state a listener was created in

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8LazyEventListener.cpp

Issue 1419313003: Track the script state a listener was created in (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp ('k') | third_party/WebKit/Source/bindings/core/v8/V8MutationCallback.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/V8LazyEventListener.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8LazyEventListener.cpp b/third_party/WebKit/Source/bindings/core/v8/V8LazyEventListener.cpp

index 4ae87b714d62219ec8d7106408cc15409be0d0f6..d5a989d40b9c93a045ef184376ab7e9cde65df35 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8LazyEventListener.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/V8LazyEventListener.cpp

@@ -105,7 +105,7 @@ v8::Local<v8::Value> V8LazyEventListener::callListenerFunction(ScriptState* scri

static void V8LazyEventListenerToString(const v8::FunctionCallbackInfo<v8::Value>& info)

{

- v8SetReturnValue(info, V8HiddenValue::getHiddenValue(info.GetIsolate(), info.Holder(), V8HiddenValue::toStringString(info.GetIsolate())));

+ v8SetReturnValue(info, V8HiddenValue::getHiddenValue(ScriptState::current(info.GetIsolate()), info.Holder(), V8HiddenValue::toStringString(info.GetIsolate())));

}

void V8LazyEventListener::prepareListenerObject(ExecutionContext* executionContext)

@@ -188,7 +188,7 @@ void V8LazyEventListener::prepareListenerObject(ExecutionContext* executionConte

if (toStringFunction.IsEmpty())

return;

String toStringString = "function " + m_functionName + "(" + m_eventParameterName + ") {\n " + m_code + "\n}";

- V8HiddenValue::setHiddenValue(isolate(), wrappedFunction, V8HiddenValue::toStringString(isolate()), v8String(isolate(), toStringString));

+ V8HiddenValue::setHiddenValue(scriptState, wrappedFunction, V8HiddenValue::toStringString(isolate()), v8String(isolate(), toStringString));

if (!v8CallBoolean(wrappedFunction->Set(scriptState->context(), v8AtomicString(isolate(), "toString"), toStringFunction)))

return;

wrappedFunction->SetName(v8String(isolate(), m_functionName));

@@ -203,7 +203,7 @@ void V8LazyEventListener::prepareListenerObject(ExecutionContext* executionConte

// m_code = String();

// m_eventParameterName = String();

// m_sourceURL = String();

- setListenerObject(wrappedFunction);

+ setListenerObject(wrappedFunction, scriptState);

}

void V8LazyEventListener::fireErrorEvent(v8::Local<v8::Context> v8Context, ExecutionContext* executionContext, v8::Local<v8::Message> message)