Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8HiddenValue.cpp

Issue 1419313003: Track the script state a listener was created in (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/V8HiddenValue.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8HiddenValue.cpp b/third_party/WebKit/Source/bindings/core/v8/V8HiddenValue.cpp
index 77bb76e1f21e11fe8afd7c14ba53382e4d85d755..c0e1cc64ca5db06b60c0461146fdd027c87356c2 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8HiddenValue.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/V8HiddenValue.cpp
@@ -5,6 +5,7 @@
#include "config.h"
#include "bindings/core/v8/V8HiddenValue.h"
+#include "bindings/core/v8/ScriptState.h"
#include "bindings/core/v8/ScriptWrappable.h"
#include "bindings/core/v8/V8Binding.h"
@@ -22,25 +23,25 @@ v8::Local<v8::String> V8HiddenValue::name(v8::Isolate* isolate) \
V8_HIDDEN_VALUES(V8_DEFINE_METHOD);
-v8::Local<v8::Value> V8HiddenValue::getHiddenValue(v8::Isolate* isolate, v8::Local<v8::Object> object, v8::Local<v8::String> key)
+v8::Local<v8::Value> V8HiddenValue::getHiddenValue(ScriptState* scriptState, v8::Local<v8::Object> object, v8::Local<v8::String> key)
{
return object->GetHiddenValue(key);
}
-bool V8HiddenValue::setHiddenValue(v8::Isolate* isolate, v8::Local<v8::Object> object, v8::Local<v8::String> key, v8::Local<v8::Value> value)
+bool V8HiddenValue::setHiddenValue(ScriptState* scriptState, v8::Local<v8::Object> object, v8::Local<v8::String> key, v8::Local<v8::Value> value)
{
return object->SetHiddenValue(key, value);
}
-bool V8HiddenValue::deleteHiddenValue(v8::Isolate* isolate, v8::Local<v8::Object> object, v8::Local<v8::String> key)
+bool V8HiddenValue::deleteHiddenValue(ScriptState* scriptState, v8::Local<v8::Object> object, v8::Local<v8::String> key)
{
return object->DeleteHiddenValue(key);
}
-v8::Local<v8::Value> V8HiddenValue::getHiddenValueFromMainWorldWrapper(v8::Isolate* isolate, ScriptWrappable* wrappable, v8::Local<v8::String> key)
+v8::Local<v8::Value> V8HiddenValue::getHiddenValueFromMainWorldWrapper(ScriptState* scriptState, ScriptWrappable* wrappable, v8::Local<v8::String> key)
{
- v8::Local<v8::Object> wrapper = wrappable->newLocalWrapper(isolate);
- return wrapper.IsEmpty() ? v8::Local<v8::Value>() : getHiddenValue(isolate, wrapper, key);
+ v8::Local<v8::Object> wrapper = wrappable->newLocalWrapper(scriptState->isolate());
+ return wrapper.IsEmpty() ? v8::Local<v8::Value>() : getHiddenValue(scriptState, wrapper, key);
}
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698