third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.h - Issue 1419313003: Track the script state a listener was created in

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.h

Issue 1419313003: Track the script state a listener was created in (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyBase.cpp ('k') | third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.h b/third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.h

index bb3d36aafffe38cbd235ec3e6a165aa0867c1eca..fdb454f67910e54419c7ef754ca6f7b89b9c4876 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.h

+++ b/third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.h

@@ -129,7 +129,7 @@ protected:

virtual void prepareListenerObject(ExecutionContext*) { }

- void setListenerObject(v8::Local<v8::Object>);

+ void setListenerObject(v8::Local<v8::Object>, ScriptState*);

void invokeEventHandler(ScriptState*, Event*, v8::Local<v8::Value>);

@@ -148,6 +148,8 @@ private:

static void setWeakCallback(const v8::WeakCallbackInfo<V8AbstractEventListener>&);

+ // The ScriptState the m_listener below was created in.

+ RefPtr<ScriptState> m_scriptStateForListener;

ScopedPersistent<v8::Object> m_listener;

// Indicates if this is an HTML type listener.