third_party/WebKit/Source/bindings/core/v8/PrivateScriptRunner.cpp - Issue 1419313003: Track the script state a listener was created in

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/PrivateScriptRunner.cpp

Issue 1419313003: Track the script state a listener was created in (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/CustomElementConstructorBuilder.cpp ('k') | third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyBase.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/PrivateScriptRunner.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/PrivateScriptRunner.cpp b/third_party/WebKit/Source/bindings/core/v8/PrivateScriptRunner.cpp

index 3f0c2b2099113123c4bf7f9ac4ebadcd51b489e0..d6dd87f70fc9c59c75febb8451b642c07b1ea60e 100644

--- a/third_party/WebKit/Source/bindings/core/v8/PrivateScriptRunner.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/PrivateScriptRunner.cpp

@@ -190,7 +190,7 @@ static void initializeHolderIfNeeded(ScriptState* scriptState, v8::Local<v8::Obj

v8::Local<v8::Object> holderObject = v8::Local<v8::Object>::Cast(holder);

v8::Isolate* isolate = scriptState->isolate();

v8::Local<v8::Context> context = scriptState->context();

- v8::Local<v8::Value> isInitialized = V8HiddenValue::getHiddenValue(isolate, holderObject, V8HiddenValue::privateScriptObjectIsInitialized(isolate));

+ v8::Local<v8::Value> isInitialized = V8HiddenValue::getHiddenValue(scriptState, holderObject, V8HiddenValue::privateScriptObjectIsInitialized(isolate));

if (isInitialized.IsEmpty()) {

v8::TryCatch block;

v8::Local<v8::Value> initializeFunction;

@@ -222,7 +222,7 @@ static void initializeHolderIfNeeded(ScriptState* scriptState, v8::Local<v8::Obj

}

isInitialized = v8Boolean(true, isolate);

- V8HiddenValue::setHiddenValue(isolate, holderObject, V8HiddenValue::privateScriptObjectIsInitialized(isolate), isInitialized);

+ V8HiddenValue::setHiddenValue(scriptState, holderObject, V8HiddenValue::privateScriptObjectIsInitialized(isolate), isInitialized);

}