third_party/WebKit/Source/core/fetch/CachingCorrectnessTest.cpp - Issue 1419293005: Add assertions that the empty Platform::cryptographicallyRandomValues() overrides are not being use…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/fetch/CachingCorrectnessTest.cpp

Issue 1419293005: Add assertions that the empty Platform::cryptographicallyRandomValues() overrides are not being use… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Change to RELEASE_ASSERT and use base::RandBytes() in Chromium. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/dom/ScriptRunnerTest.cpp ('k') | third_party/WebKit/Source/platform/TestingPlatformSupport.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/fetch/CachingCorrectnessTest.cpp

diff --git a/third_party/WebKit/Source/core/fetch/CachingCorrectnessTest.cpp b/third_party/WebKit/Source/core/fetch/CachingCorrectnessTest.cpp

index c772cf3d04a3a2838a51cf73b1840bd1f92bd071..17ab8dbbe704ee8b36be61ce095a8301e922c880 100644

--- a/third_party/WebKit/Source/core/fetch/CachingCorrectnessTest.cpp

+++ b/third_party/WebKit/Source/core/fetch/CachingCorrectnessTest.cpp

@@ -147,7 +147,10 @@ private:

}

// These blink::Platform methods must be overriden to make a usable object.

- virtual void cryptographicallyRandomValues(unsigned char* buffer, size_t length) { ASSERT_NOT_REACHED(); }

+ virtual void cryptographicallyRandomValues(unsigned char* buffer, size_t length)

+ {

+ RELEASE_ASSERT_NOT_REACHED();

+ }

virtual const unsigned char* getTraceCategoryEnabledFlag(const char* categoryName)

{

return &kAConstUnsignedCharZero;