Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 1419293003: Allow mojo_runner to connect to arbitrary executables. (Closed)

Created:
5 years, 1 month ago by Ben Goodger (Google)
Modified:
5 years, 1 month ago
Reviewers:
jam
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow mojo_runner to connect to arbitrary executables. - Introduces a new scheme "exe" which loads an executable alongside mojo_runner. TODO is some more security checking around this to prevent arbitrary apps from launching executables but since this is implemented in mojo_runner it's not in any production code right now. - Includes an apptest of a .mojo app that connects to an executable and binds a service provided by it. - Creates a new child library that makes it easy to bring up a runner controller thread in an arbitrary executable. R=jam@chromium.org http://crbug.com/548694 Committed: https://crrev.com/48799d724056efafd4bc7faa6e77459fbd1efad0 Cr-Commit-Position: refs/heads/master@{#357034}

Patch Set 1 #

Patch Set 2 : . #

Total comments: 1

Patch Set 3 : . #

Patch Set 4 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+618 lines, -64 lines) Patch
M mojo/application/public/cpp/BUILD.gn View 1 chunk +0 lines, -3 lines 0 comments Download
M mojo/fetcher/url_resolver.cc View 1 2 3 1 chunk +17 lines, -7 lines 0 comments Download
M mojo/runner/BUILD.gn View 8 chunks +10 lines, -25 lines 0 comments Download
A mojo/runner/child/BUILD.gn View 1 2 1 chunk +97 lines, -0 lines 0 comments Download
A + mojo/runner/child/child_controller.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
A mojo/runner/child/native_apptest.cc View 1 2 1 chunk +42 lines, -0 lines 0 comments Download
A mojo/runner/child/native_apptest_target.cc View 1 2 1 chunk +126 lines, -0 lines 0 comments Download
A mojo/runner/child/runner_connection.h View 1 chunk +39 lines, -0 lines 0 comments Download
A mojo/runner/child/runner_connection.cc View 1 chunk +257 lines, -0 lines 0 comments Download
A + mojo/runner/child/test_native_service.mojom View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/runner/child_process.cc View 1 chunk +1 line, -1 line 0 comments Download
D mojo/runner/child_process.mojom View 1 chunk +0 lines, -15 lines 0 comments Download
M mojo/runner/child_process_host.h View 1 1 chunk +1 line, -1 line 0 comments Download
M mojo/runner/child_process_host.cc View 1 2 3 1 chunk +11 lines, -2 lines 0 comments Download
M mojo/runner/in_process_native_runner.h View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/runner/in_process_native_runner.cc View 2 chunks +6 lines, -1 line 0 comments Download
M mojo/runner/native_runner_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M mojo/runner/out_of_process_native_runner.h View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/runner/out_of_process_native_runner.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/shell/application_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/native_runner.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
Ben Goodger (Google)
5 years, 1 month ago (2015-10-29 21:32:52 UTC) #1
jam
lgtm https://codereview.chromium.org/1419293003/diff/20001/mojo/runner/child/native_service.mojom File mojo/runner/child/native_service.mojom (right): https://codereview.chromium.org/1419293003/diff/20001/mojo/runner/child/native_service.mojom#newcode1 mojo/runner/child/native_service.mojom:1: // Copyright 2015 The Chromium Authors. All rights ...
5 years, 1 month ago (2015-10-29 22:10:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1419293003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1419293003/40001
5 years, 1 month ago (2015-10-29 22:41:43 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/133523)
5 years, 1 month ago (2015-10-29 23:25:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1419293003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1419293003/60001
5 years, 1 month ago (2015-10-30 01:48:28 UTC) #10
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 1 month ago (2015-10-30 02:48:20 UTC) #11
commit-bot: I haz the power
5 years, 1 month ago (2015-10-30 02:49:35 UTC) #12
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/48799d724056efafd4bc7faa6e77459fbd1efad0
Cr-Commit-Position: refs/heads/master@{#357034}

Powered by Google App Engine
This is Rietveld 408576698