Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Unified Diff: cc/trees/threaded_channel.h

Issue 1419283002: cc: Split Proxy and TaskRunnerProvider for the LayerTreeHost (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/trees/thread_proxy.cc ('k') | cc/trees/threaded_channel.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/trees/threaded_channel.h
diff --git a/cc/trees/threaded_channel.h b/cc/trees/threaded_channel.h
index 1a4b8b7027ad2acf883fc730def38235f6701a94..a337593f71a8eaed007dc60770e69bd202fa8087 100644
--- a/cc/trees/threaded_channel.h
+++ b/cc/trees/threaded_channel.h
@@ -70,8 +70,7 @@ class CC_EXPORT ThreadedChannel : public ChannelMain, public ChannelImpl {
// sequence. Currently ThreadProxy implements both so we pass the pointer
// and set ProxyImpl.
ThreadProxy* thread_proxy,
- scoped_refptr<base::SingleThreadTaskRunner> main_task_runner,
- scoped_refptr<base::SingleThreadTaskRunner> impl_task_runner);
+ TaskRunnerProvider* task_runner_provider);
~ThreadedChannel() override;
@@ -125,8 +124,7 @@ class CC_EXPORT ThreadedChannel : public ChannelMain, public ChannelImpl {
protected:
ThreadedChannel(ThreadProxy* thread_proxy,
- scoped_refptr<base::SingleThreadTaskRunner> main_task_runner,
- scoped_refptr<base::SingleThreadTaskRunner> impl_task_runner);
+ TaskRunnerProvider* task_runner_provider);
private:
base::SingleThreadTaskRunner* MainThreadTaskRunner() const;
@@ -136,11 +134,7 @@ class CC_EXPORT ThreadedChannel : public ChannelMain, public ChannelImpl {
ProxyImpl* proxy_impl_;
- // TODO(khushalsagar): Temporary variable to access proxy for assertion checks
- // Remove this once the proxy class is split and the complete
- // implementation for controlling communication across threads is moved to
- // ThreadedChannel.
- Proxy* proxy_;
+ TaskRunnerProvider* task_runner_provider_;
scoped_refptr<base::SingleThreadTaskRunner> main_task_runner_;
« no previous file with comments | « cc/trees/thread_proxy.cc ('k') | cc/trees/threaded_channel.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698