Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Unified Diff: cc/trees/proxy.h

Issue 1419283002: cc: Split Proxy and TaskRunnerProvider for the LayerTreeHost (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add missing include in perf test. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/trees/proxy.h
diff --git a/cc/trees/proxy.h b/cc/trees/proxy.h
index 8780281384bd3851de2cbb020829302033d41b89..fa6a76ac3a51a49a6a1f93c741ed9b48073a5d77 100644
--- a/cc/trees/proxy.h
+++ b/cc/trees/proxy.h
@@ -28,12 +28,10 @@ class LayerTreeDebugState;
class OutputSurface;
struct RendererCapabilities;
-// Abstract class responsible for proxying commands from the main-thread side of
-// the compositor over to the compositor implementation.
-class CC_EXPORT Proxy : public TaskRunnerProvider {
+// Abstract interface responsible for proxying commands from the main-thread
+// side of the compositor over to the compositor implementation.
+class CC_EXPORT Proxy {
public:
- ~Proxy() override;
-
virtual void FinishAllRendering() = 0;
virtual bool IsStarted() const = 0;
@@ -86,12 +84,7 @@ class CC_EXPORT Proxy : public TaskRunnerProvider {
// Testing hooks
virtual bool MainFrameWillHappenForTesting() = 0;
- protected:
- Proxy(scoped_refptr<base::SingleThreadTaskRunner> main_task_runner,
- scoped_refptr<base::SingleThreadTaskRunner> impl_task_runner);
-
- private:
- DISALLOW_COPY_AND_ASSIGN(Proxy);
+ virtual ~Proxy() {}
vmpstr 2015/11/10 21:59:34 dtors should be at the top.
Khushal 2015/11/10 23:34:03 Done.
};
} // namespace cc

Powered by Google App Engine
This is Rietveld 408576698