Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Unified Diff: third_party/libjingle/libjingle.gyp

Issue 1419253002: Rearrange dependency to enable adding finch experiment in webrtc (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: formatting BUILD.gn Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/libjingle/libjingle.gyp
diff --git a/third_party/libjingle/libjingle.gyp b/third_party/libjingle/libjingle.gyp
index 19ed24a9c8062e29afff68e74431dcd941e1330f..3290cbb86646e1884d292b4499da16e5a5009d4a 100644
--- a/third_party/libjingle/libjingle.gyp
+++ b/third_party/libjingle/libjingle.gyp
@@ -244,6 +244,11 @@
'<(webrtc_p2p)/base/constants.cc',
'<(webrtc_p2p)/base/constants.h',
],
+ # p2ptransportchannel.cc now depends on field_trial. For NACL build, a
Sergey Ulanov 2015/10/26 17:43:31 I don't think you need to mention the name of the
guoweis_left_chromium 2015/10/26 18:16:44 Done.
+ # default implementation is added instead in libjingle_nacl.
+ 'sources': [
Sergey Ulanov 2015/10/26 17:43:31 For consistency with other overrides please move t
guoweis_left_chromium 2015/10/26 18:16:44 Done.
+ 'overrides/field_trial.cc',
+ ],
'dependencies': [
'<(DEPTH)/third_party/webrtc/base/base.gyp:rtc_base',
'<(DEPTH)/third_party/webrtc/libjingle/xmllite/xmllite.gyp:rtc_xmllite',

Powered by Google App Engine
This is Rietveld 408576698