win: Don't use delegate_execute to relaunch on Win10+

win: Don't use delegate_execute to relaunch on Win10+

I think we were mistakenly using delegate_execute to relaunch even on
Win10. Possibly some DEx changes, or possibly some shortcut changes
eventually broke this, so just launch directly like we do on <= 7.

R=grt@chromium.org, gab@chromium.org
BUG=548965
Committed: https://crrev.com/d3839f0b456e261c7b10c45898658d0790ccd571
Cr-Commit-Position: refs/heads/master@{#356988}

[scottmg, 2015-10-29 20:44:58]

Description was changed from

==========
win: Don't use delegate_execute to relaunch on Win10+

I think we were mistakenly using delegate_execute to relaunch even on
Win10. Possibly some DEx changes, or possibly some shortcut changes
eventually broke this, so just launch directly like we do on <= 7.

R=grt@chromium.org
BUG=548965
==========

to

==========
win: Don't use delegate_execute to relaunch on Win10+

I think we were mistakenly using delegate_execute to relaunch even on
Win10. Possibly some DEx changes, or possibly some shortcut changes
eventually broke this, so just launch directly like we do on <= 7.

R=grt@chromium.org
BUG=548965
==========

[scottmg, 2015-10-29 20:44:58]

scottmg@chromium.org changed reviewers:
+ gab@chromium.org

[scottmg, 2015-10-29 21:02:05]

The CQ bit was checked by scottmg@chromium.org to run a CQ dry run

[scottmg, 2015-10-29 21:02:16]

Description was changed from

==========
win: Don't use delegate_execute to relaunch on Win10+

I think we were mistakenly using delegate_execute to relaunch even on
Win10. Possibly some DEx changes, or possibly some shortcut changes
eventually broke this, so just launch directly like we do on <= 7.

R=grt@chromium.org
BUG=548965
==========

to

==========
win: Don't use delegate_execute to relaunch on Win10+

I think we were mistakenly using delegate_execute to relaunch even on
Win10. Possibly some DEx changes, or possibly some shortcut changes
eventually broke this, so just launch directly like we do on <= 7.

R=grt@chromium.org, gab@chromium.org
BUG=548965
==========

[commit-bot: I haz the power, 2015-10-29 21:06:02]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1419223006/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1419223006/1

[gab, 2015-10-29 21:06:05]

lgtm, I don't think the DEx changes caused these bugs, but this should
definitely have happened with them.

https://codereview.chromium.org/1419223006/diff/1/chrome/browser/first_run/up...
File chrome/browser/first_run/upgrade_util_win.cc (right):

https://codereview.chromium.org/1419223006/diff/1/chrome/browser/first_run/up...
chrome/browser/first_run/upgrade_util_win.cc:165: base::win::GetVersion() !=
base::win::VERSION_WIN8_1 &&
I tend to prefer version ranges to strict comparison (i.e. <Win8 >=Win10
highlights the intent better.

https://codereview.chromium.org/1419223006/diff/1/chrome/browser/first_run/up...
chrome/browser/first_run/upgrade_util_win.cc:167: relaunch_mode !=
RELAUNCH_MODE_DESKTOP) {
Does the |relaunch_mode| really matter on non-Win8?

[scottmg, 2015-10-29 21:29:28]

Patchset #2 (id:20001) has been deleted

[scottmg, 2015-10-29 21:30:36]

https://codereview.chromium.org/1419223006/diff/1/chrome/browser/first_run/up...
File chrome/browser/first_run/upgrade_util_win.cc (right):

https://codereview.chromium.org/1419223006/diff/1/chrome/browser/first_run/up...
chrome/browser/first_run/upgrade_util_win.cc:165: base::win::GetVersion() !=
base::win::VERSION_WIN8_1 &&
On 2015/10/29 21:06:05, gab wrote:
> I tend to prefer version ranges to strict comparison (i.e. <Win8 >=Win10
> highlights the intent better.

Done.

https://codereview.chromium.org/1419223006/diff/1/chrome/browser/first_run/up...
chrome/browser/first_run/upgrade_util_win.cc:167: relaunch_mode !=
RELAUNCH_MODE_DESKTOP) {
On 2015/10/29 21:06:05, gab wrote:
> Does the |relaunch_mode| really matter on non-Win8?

I ... don't know. It seems like it shouldn't, I guess it's probably for the fake
ash mode on Win7?

[scottmg, 2015-10-29 21:39:05]

The CQ bit was checked by scottmg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-29 21:40:23]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1419223006/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1419223006/40001

[scottmg, 2015-10-29 22:28:18]

The CQ bit was unchecked by scottmg@chromium.org

[scottmg, 2015-10-29 22:28:23]

The CQ bit was checked by scottmg@chromium.org

[scottmg, 2015-10-29 22:28:24]

The patchset sent to the CQ was uploaded after l-g-t-m from gab@chromium.org
Link to the patchset: https://codereview.chromium.org/1419223006/#ps40001
(title: "fixes")

[commit-bot: I haz the power, 2015-10-29 22:29:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-29 22:29:39]

Dry run: This issue passed the CQ dry run.

[scottmg, 2015-10-29 23:41:08]

The CQ bit was checked by scottmg@chromium.org

[commit-bot: I haz the power, 2015-10-29 23:41:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1419223006/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1419223006/40001

[commit-bot: I haz the power, 2015-10-29 23:54:00]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2015-10-29 23:54:41]

Patchset 2 (id:??) landed as
https://crrev.com/d3839f0b456e261c7b10c45898658d0790ccd571
Cr-Commit-Position: refs/heads/master@{#356988}