runtime/vm/intrinsifier_ia32.cc - Issue 1419223003: Re-assign registers on ARM so PP and CODE_REG are below R7 (FP on iOS).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/intrinsifier_ia32.cc

Issue 1419223003: Re-assign registers on ARM so PP and CODE_REG are below R7 (FP on iOS). (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/intrinsifier_ia32.cc

diff --git a/runtime/vm/intrinsifier_ia32.cc b/runtime/vm/intrinsifier_ia32.cc

index d39f3b66007eadfb3dbfb48550ab94afe9757055..a539284352df54c2b5f07c8422fcfcc2d5be3cc6 100644

--- a/runtime/vm/intrinsifier_ia32.cc

+++ b/runtime/vm/intrinsifier_ia32.cc

@@ -33,6 +33,7 @@ DECLARE_FLAG(bool, interpret_irregexp);

// The ECX, EDX registers can be destroyed only if there is no slow-path, i.e.

// if the intrinsified method always executes a return.

// The EBP register should not be modified, because it is used by the profiler.

+// The THR register (see constants_ia32.h) must be preserved.

#define __ assembler->

« runtime/vm/intrinsifier_arm.cc ('K') | « runtime/vm/intrinsifier_arm64.cc ('k') | runtime/vm/intrinsifier_mips.cc » ('j') | no next file with comments »