runtime/vm/flow_graph_compiler.cc - Issue 1419223003: Re-assign registers on ARM so PP and CODE_REG are below R7 (FP on iOS).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_compiler.cc

Issue 1419223003: Re-assign registers on ARM so PP and CODE_REG are below R7 (FP on iOS). (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/flow_graph_compiler.cc

diff --git a/runtime/vm/flow_graph_compiler.cc b/runtime/vm/flow_graph_compiler.cc

index 79d9e6158730f4c3ed159f0638931ce408669345..73c4fbaa6518aa0ac89c1e4aa0cc522499fabbf5 100644

--- a/runtime/vm/flow_graph_compiler.cc

+++ b/runtime/vm/flow_graph_compiler.cc

@@ -1553,6 +1553,7 @@ ParallelMoveResolver::ScratchRegisterScope::ScratchRegisterScope(

if (resolver->compiler_->intrinsic_mode()) {

// Block additional registers that must be preserved for intrinsics.

blocked_mask |= RegMaskBit(ARGS_DESC_REG);

+ blocked_mask |= RegMaskBit(CODE_REG);

}

reg_ = static_cast<Register>(

resolver_->AllocateScratchRegister(Location::kRegister,

« no previous file with comments | « runtime/vm/flow_graph_allocator.cc ('k') | runtime/vm/flow_graph_compiler_arm.cc » ('j') | runtime/vm/instructions_arm.cc » ('J')