Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Side by Side Diff: runtime/vm/intrinsifier_ia32.cc

Issue 1419223003: Re-assign registers on ARM so PP and CODE_REG are below R7 (FP on iOS). (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/intrinsifier_arm64.cc ('k') | runtime/vm/intrinsifier_mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 // 4 //
5 // The intrinsic code below is executed before a method has built its frame. 5 // The intrinsic code below is executed before a method has built its frame.
6 // The return address is on the stack and the arguments below it. 6 // The return address is on the stack and the arguments below it.
7 // Registers EDX (arguments descriptor) and ECX (function) must be preserved. 7 // Registers EDX (arguments descriptor) and ECX (function) must be preserved.
8 // Each intrinsification method returns true if the corresponding 8 // Each intrinsification method returns true if the corresponding
9 // Dart method was intrinsified. 9 // Dart method was intrinsified.
10 10
(...skipping 15 matching lines...) Expand all
26 26
27 DECLARE_FLAG(bool, interpret_irregexp); 27 DECLARE_FLAG(bool, interpret_irregexp);
28 28
29 // When entering intrinsics code: 29 // When entering intrinsics code:
30 // ECX: IC Data 30 // ECX: IC Data
31 // EDX: Arguments descriptor 31 // EDX: Arguments descriptor
32 // TOS: Return address 32 // TOS: Return address
33 // The ECX, EDX registers can be destroyed only if there is no slow-path, i.e. 33 // The ECX, EDX registers can be destroyed only if there is no slow-path, i.e.
34 // if the intrinsified method always executes a return. 34 // if the intrinsified method always executes a return.
35 // The EBP register should not be modified, because it is used by the profiler. 35 // The EBP register should not be modified, because it is used by the profiler.
36 // The THR register (see constants_ia32.h) must be preserved.
36 37
37 #define __ assembler-> 38 #define __ assembler->
38 39
39 40
40 intptr_t Intrinsifier::ParameterSlotFromSp() { return 0; } 41 intptr_t Intrinsifier::ParameterSlotFromSp() { return 0; }
41 42
42 43
43 static intptr_t ComputeObjectArrayTypeArgumentsOffset() { 44 static intptr_t ComputeObjectArrayTypeArgumentsOffset() {
44 const Library& core_lib = Library::Handle(Library::CoreLibrary()); 45 const Library& core_lib = Library::Handle(Library::CoreLibrary());
45 const Class& cls = Class::Handle( 46 const Class& cls = Class::Handle(
(...skipping 2100 matching lines...) Expand 10 before | Expand all | Expand 10 after
2146 void Intrinsifier::Profiler_getCurrentTag(Assembler* assembler) { 2147 void Intrinsifier::Profiler_getCurrentTag(Assembler* assembler) {
2147 __ LoadIsolate(EAX); 2148 __ LoadIsolate(EAX);
2148 __ movl(EAX, Address(EAX, Isolate::current_tag_offset())); 2149 __ movl(EAX, Address(EAX, Isolate::current_tag_offset()));
2149 __ ret(); 2150 __ ret();
2150 } 2151 }
2151 2152
2152 #undef __ 2153 #undef __
2153 } // namespace dart 2154 } // namespace dart
2154 2155
2155 #endif // defined TARGET_ARCH_IA32 2156 #endif // defined TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « runtime/vm/intrinsifier_arm64.cc ('k') | runtime/vm/intrinsifier_mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698