Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Side by Side Diff: runtime/vm/code_patcher_arm_test.cc

Issue 1419223003: Re-assign registers on ARM so PP and CODE_REG are below R7 (FP on iOS). (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" 5 #include "vm/globals.h"
6 #if defined(TARGET_ARCH_ARM) 6 #if defined(TARGET_ARCH_ARM)
7 7
8 #include "vm/assembler.h" 8 #include "vm/assembler.h"
9 #include "vm/code_generator.h" 9 #include "vm/code_generator.h"
10 #include "vm/code_patcher.h" 10 #include "vm/code_patcher.h"
(...skipping 24 matching lines...) Expand all
35 Array::Handle(ArgumentsDescriptor::New(1, Object::null_array())); 35 Array::Handle(ArgumentsDescriptor::New(1, Object::null_array()));
36 const ICData& ic_data = ICData::ZoneHandle(ICData::New(function, 36 const ICData& ic_data = ICData::ZoneHandle(ICData::New(function,
37 target_name, 37 target_name,
38 args_descriptor, 38 args_descriptor,
39 15, 39 15,
40 1)); 40 1));
41 41
42 // Code accessing pp is generated, but not executed. Uninitialized pp is OK. 42 // Code accessing pp is generated, but not executed. Uninitialized pp is OK.
43 __ set_constant_pool_allowed(true); 43 __ set_constant_pool_allowed(true);
44 44
45 __ LoadObject(R5, ic_data); 45 __ LoadObject(R9, ic_data);
46 __ BranchLinkPatchable(*StubCode::OneArgCheckInlineCache_entry()); 46 __ BranchLinkPatchable(*StubCode::OneArgCheckInlineCache_entry());
47 __ Ret(); 47 __ Ret();
48 } 48 }
49 49
50 50
51 ASSEMBLER_TEST_RUN(IcDataAccess, test) { 51 ASSEMBLER_TEST_RUN(IcDataAccess, test) {
52 uword return_address = 52 uword return_address =
53 test->entry() + test->code().Size() - Instr::kInstrSize; 53 test->entry() + test->code().Size() - Instr::kInstrSize;
54 ICData& ic_data = ICData::Handle(); 54 ICData& ic_data = ICData::Handle();
55 CodePatcher::GetInstanceCallAt(return_address, test->code(), &ic_data); 55 CodePatcher::GetInstanceCallAt(return_address, test->code(), &ic_data);
56 EXPECT_STREQ("targetFunction", 56 EXPECT_STREQ("targetFunction",
57 String::Handle(ic_data.target_name()).ToCString()); 57 String::Handle(ic_data.target_name()).ToCString());
58 EXPECT_EQ(1, ic_data.NumArgsTested()); 58 EXPECT_EQ(1, ic_data.NumArgsTested());
59 EXPECT_EQ(0, ic_data.NumberOfChecks()); 59 EXPECT_EQ(0, ic_data.NumberOfChecks());
60 } 60 }
61 61
62 } // namespace dart 62 } // namespace dart
63 63
64 #endif // TARGET_ARCH_ARM 64 #endif // TARGET_ARCH_ARM
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698