Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 1419213006: Require secure contexts and user gestures to use WebUSB. (Closed)

Created:
5 years, 1 month ago by Reilly Grant (use Gerrit)
Modified:
5 years, 1 month ago
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Require secure contexts and user gestures to use WebUSB. Adds checks in Blink to only allow secure contexts to call getDevices and requestDevice. As requestDevice also displays a permission prompt it also requires a user gesture. BUG=492204 Committed: https://crrev.com/3a7f1e35efc1b70975193ec4b475e74b59bdf63c Cr-Commit-Position: refs/heads/master@{#359021}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M third_party/WebKit/Source/modules/webusb/USB.cpp View 3 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Reilly Grant (use Gerrit)
PTAL
5 years, 1 month ago (2015-11-10 23:55:42 UTC) #2
Ken Rockot(use gerrit already)
lgtm
5 years, 1 month ago (2015-11-11 00:44:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1419213006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1419213006/1
5 years, 1 month ago (2015-11-11 00:45:21 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-11 02:28:07 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-11 02:28:47 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3a7f1e35efc1b70975193ec4b475e74b59bdf63c
Cr-Commit-Position: refs/heads/master@{#359021}

Powered by Google App Engine
This is Rietveld 408576698