Web MIDI: implement MIDIMessageEvent

Web MIDI: implement MIDIMessageEvent

This change implements MIDIMessageEvent behind a runtime flag.

BUG=163795
TEST=LayoutTests/fast/events/constructors/midi-message-event-constructor.html

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=148885

[Takashi Toyoshima, 2013-04-22 17:24:01]

Hi Chris,
How about starting from MIDIMessageEvent.
Try doesn't work because git confused new files as moved files. But it works in
my local machine.

[abarth-chromium, 2013-04-22 17:55:39]

LGTM, with one naming nit below.

https://codereview.chromium.org/14192043/diff/3001/Source/modules/modules.gypi
File Source/modules/modules.gypi (right):

https://codereview.chromium.org/14192043/diff/3001/Source/modules/modules.gyp...
Source/modules/modules.gypi:176: 'webmidi/DOMWindowMIDI.idl',
Generally we try to match the name of the module with the IDL suffix.  For
example, you could change the directory to be called "midi" or the IDL file to
be called DOMWindowWebMIDI.  Either is fine, but this mismatch is slightly out
of the norm.

[Chris Rogers, 2013-04-22 19:31:57]

https://codereview.chromium.org/14192043/diff/3001/Source/modules/modules.gypi
File Source/modules/modules.gypi (right):

https://codereview.chromium.org/14192043/diff/3001/Source/modules/modules.gyp...
Source/modules/modules.gypi:176: 'webmidi/DOMWindowMIDI.idl',
On 2013/04/22 17:55:39, abarth wrote:
> Generally we try to match the name of the module with the IDL suffix.  For
> example, you could change the directory to be called "midi" or the IDL file to
> be called DOMWindowWebMIDI.  Either is fine, but this mismatch is slightly out
> of the norm.

I'd recommend changing the .idl to DOMWindowWebMIDI.idl

https://codereview.chromium.org/14192043/diff/3001/Source/modules/webmidi/MID...
File Source/modules/webmidi/MIDIMessageEvent.h (right):

https://codereview.chromium.org/14192043/diff/3001/Source/modules/webmidi/MID...
Source/modules/webmidi/MIDIMessageEvent.h:56: static
PassRefPtr<MIDIMessageEvent> create(double receivedTime, RefPtr<Uint8Array>
data)
RefPtr -> PassRefPtr?

https://codereview.chromium.org/14192043/diff/3001/Source/modules/webmidi/MID...
Source/modules/webmidi/MIDIMessageEvent.h:67: RefPtr<Uint8Array> data() { return
m_data; }
Seems like this could be PassRefPtr?  Adam?

https://codereview.chromium.org/14192043/diff/3001/Source/modules/webmidi/MID...
Source/modules/webmidi/MIDIMessageEvent.h:76: MIDIMessageEvent(double
receivedTime, RefPtr<Uint8Array> data)
RefPtr -> PassRefPtr?

https://codereview.chromium.org/14192043/diff/3001/Source/modules/webmidi/OWNERS
File Source/modules/webmidi/OWNERS (right):

https://codereview.chromium.org/14192043/diff/3001/Source/modules/webmidi/OWN...
Source/modules/webmidi/OWNERS:1: crogers@chromium.org
Please use "crogers@google.com"

[abarth-chromium, 2013-04-22 19:33:04]

https://codereview.chromium.org/14192043/diff/3001/Source/modules/webmidi/MID...
File Source/modules/webmidi/MIDIMessageEvent.h (right):

https://codereview.chromium.org/14192043/diff/3001/Source/modules/webmidi/MID...
Source/modules/webmidi/MIDIMessageEvent.h:67: RefPtr<Uint8Array> data() { return
m_data; }
On 2013/04/22 19:31:57, Chris Rogers wrote:
> Seems like this could be PassRefPtr?  Adam?

Yes.

[Takashi Toyoshima, 2013-04-23 04:24:46]

https://codereview.chromium.org/14192043/diff/3001/Source/modules/modules.gypi
File Source/modules/modules.gypi (right):

https://codereview.chromium.org/14192043/diff/3001/Source/modules/modules.gyp...
Source/modules/modules.gypi:176: 'webmidi/DOMWindowMIDI.idl',
On 2013/04/22 19:31:57, Chris Rogers wrote:
> On 2013/04/22 17:55:39, abarth wrote:
> > Generally we try to match the name of the module with the IDL suffix.  For
> > example, you could change the directory to be called "midi" or the IDL file
to
> > be called DOMWindowWebMIDI.  Either is fine, but this mismatch is slightly
out
> > of the norm.
> 
> I'd recommend changing the .idl to DOMWindowWebMIDI.idl

Done.

https://codereview.chromium.org/14192043/diff/3001/Source/modules/webmidi/MID...
File Source/modules/webmidi/MIDIMessageEvent.h (right):

https://codereview.chromium.org/14192043/diff/3001/Source/modules/webmidi/MID...
Source/modules/webmidi/MIDIMessageEvent.h:56: static
PassRefPtr<MIDIMessageEvent> create(double receivedTime, RefPtr<Uint8Array>
data)
On 2013/04/22 19:31:57, Chris Rogers wrote:
> RefPtr -> PassRefPtr?

Done.

https://codereview.chromium.org/14192043/diff/3001/Source/modules/webmidi/MID...
Source/modules/webmidi/MIDIMessageEvent.h:67: RefPtr<Uint8Array> data() { return
m_data; }
On 2013/04/22 19:31:57, Chris Rogers wrote:
> Seems like this could be PassRefPtr?  Adam?

Done.

https://codereview.chromium.org/14192043/diff/3001/Source/modules/webmidi/MID...
Source/modules/webmidi/MIDIMessageEvent.h:76: MIDIMessageEvent(double
receivedTime, RefPtr<Uint8Array> data)
On 2013/04/22 19:31:57, Chris Rogers wrote:
> RefPtr -> PassRefPtr?

Done.

[Chris Rogers, 2013-04-23 04:51:01]

lgtm with nit

https://codereview.chromium.org/14192043/diff/16001/Source/modules/webmidi/OW...
File Source/modules/webmidi/OWNERS (right):

https://codereview.chromium.org/14192043/diff/16001/Source/modules/webmidi/OW...
Source/modules/webmidi/OWNERS:1: crogers@chromium.org
Please use "crogers@google.com"

[Takashi Toyoshima, 2013-04-23 05:05:14]

Thanks!

https://codereview.chromium.org/14192043/diff/16001/Source/modules/webmidi/OW...
File Source/modules/webmidi/OWNERS (right):

https://codereview.chromium.org/14192043/diff/16001/Source/modules/webmidi/OW...
Source/modules/webmidi/OWNERS:1: crogers@chromium.org
On 2013/04/23 04:51:01, Chris Rogers wrote:
> Please use "crogers@google.com"

Done.

[commit-bot: I haz the power, 2013-04-23 05:05:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/toyoshim@chromium.org/14192043/22001

[commit-bot: I haz the power, 2013-04-23 05:11:26]

Presubmit check for 14192043-22001 failed and returned exit status -2001.
The presubmit check was hung. It took 360.0 seconds to execute and the time
limit is 360.0 seconds.

INFO:root:Found 10 file(s).

[commit-bot: I haz the power, 2013-04-23 05:23:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/toyoshim@chromium.org/14192043/22001

[commit-bot: I haz the power, 2013-04-23 05:29:04]

Presubmit check for 14192043-22001 failed and returned exit status -2001.
The presubmit check was hung. It took 360.0 seconds to execute and the time
limit is 360.0 seconds.

INFO:root:Found 10 file(s).

[Takashi Toyoshima, 2013-04-23 05:51:28]

Committed patchset #5 manually as r148885 (presubmit successful).

[tkent, 2013-04-23 06:15:58]

https://codereview.chromium.org/14192043/diff/22001/Source/modules/modules.gypi
File Source/modules/modules.gypi (right):

https://codereview.chromium.org/14192043/diff/22001/Source/modules/modules.gy...
Source/modules/modules.gypi:176: 'webmidi/DOMWindowWebMIDI.idl',
There is no DOMWindowMIDI.idl in the patch.

[Takashi Toyoshima, 2013-04-23 06:22:53]

https://codereview.chromium.org/14192043/diff/22001/Source/modules/modules.gypi
File Source/modules/modules.gypi (right):

https://codereview.chromium.org/14192043/diff/22001/Source/modules/modules.gy...
Source/modules/modules.gypi:176: 'webmidi/DOMWindowWebMIDI.idl',
Sorry, I missed to include it after renaming.
I landed it as a build fix CL.