Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: include/gpu/gl/GrGLConfig.h

Issue 1419203002: Remove mac buffer impl war (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: tweaks Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/gpu/gl/GrGLBufferImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/gpu/gl/GrGLConfig.h
diff --git a/include/gpu/gl/GrGLConfig.h b/include/gpu/gl/GrGLConfig.h
index 7c14d52a85ac5c61b84a53cbb6d532f1ce48e9bd..c91537cc380a891f2023527bb58b9519bb1ccfac 100644
--- a/include/gpu/gl/GrGLConfig.h
+++ b/include/gpu/gl/GrGLConfig.h
@@ -135,35 +135,4 @@
#define GR_GL_USE_NEW_SHADER_SOURCE_SIGNATURE 0
#endif
-/**
- * There is a strange bug that occurs on Macs with NVIDIA GPUs. We don't
- * fully understand it. When (element) array buffers are continually
- * respecified using glBufferData performance can fall off of a cliff. The
- * driver winds up performing many DMA mapping / unmappings and chews up ~50% of
- * the core. However, it has been observed that occaisonally respecifiying the
- * buffer using glBufferData and then writing data using glBufferSubData
- * prevents the bad behavior.
- *
- * There is a lot of uncertainty around this issue. In Chrome backgrounding
- * the tab somehow initiates this behavior and we don't know what the connection
- * is. Another observation is that Chrome's cmd buffer server will actually
- * create a buffer full of zeros when it sees a NULL data param (for security
- * reasons). If this is disabled and NULL is actually passed all the way to the
- * driver then the workaround doesn't help.
- *
- * The issue is tracked at:
- * http://code.google.com/p/chromium/issues/detail?id=114865
- *
- * When the workaround is enabled we will use the glBufferData / glBufferSubData
- * trick every 128 array buffer uploads.
- *
- * Hopefully we will understand this better and have a cleaner fix or get a
- * OS/driver level fix.
- */
-#if (defined(SK_BUILD_FOR_MAC) && !GR_GL_USE_BUFFER_DATA_NULL_HINT)
-# define GR_GL_MAC_BUFFER_OBJECT_PERFOMANCE_WORKAROUND 1
-#else
-# define GR_GL_MAC_BUFFER_OBJECT_PERFOMANCE_WORKAROUND 0
-#endif
-
#endif
« no previous file with comments | « no previous file | src/gpu/gl/GrGLBufferImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698