Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Issue 14192025: Update message center systray icon. (Closed)

Created:
7 years, 8 months ago by dewittj
Modified:
7 years, 8 months ago
Reviewers:
Jun Mukai, oshima
CC:
chromium-reviews, tfarina, oshima+watch_chromium.org
Visibility:
Public.

Description

Update message center systray icon. New design shows a notification bubble on a gray background when there are no unread notifications. When unread notifications exist, an image displaying the number of notifications (up to 9+) is rendered on a blue background. The new png is a sprite map of the digits. TEST=manually generate 11 notifications BUG=189129 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195314

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rename constants for clarity. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -3 lines) Patch
A chrome/app/theme/default_100_percent/win/notification_tray_attention.png View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/default_100_percent/win/notification_tray_dim.png View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_100_percent/win/notification_tray_empty.png View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/default_100_percent/win/notification_tray_lit.png View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/app/theme/default_100_percent/win/notification_tray_numbers.png View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/theme_resources.grd View 1 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/message_center/web_notification_tray_win.cc View 1 4 chunks +38 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
dewittj
PTAL, I'll have to commit this manually since the binaries don't get sent to the ...
7 years, 8 months ago (2013-04-19 18:15:46 UTC) #1
Jun Mukai
code looks good, but please make sure about the default icon color. https://codereview.chromium.org/14192025/diff/1/chrome/browser/ui/views/message_center/web_notification_tray_win.cc File chrome/browser/ui/views/message_center/web_notification_tray_win.cc ...
7 years, 8 months ago (2013-04-19 19:00:50 UTC) #2
Jun Mukai
oops, forgotten the four characters -- lgtm!
7 years, 8 months ago (2013-04-19 19:01:14 UTC) #3
oshima
chrome/app/theme lgtm
7 years, 8 months ago (2013-04-19 20:00:59 UTC) #4
dewittj
https://codereview.chromium.org/14192025/diff/1/chrome/browser/ui/views/message_center/web_notification_tray_win.cc File chrome/browser/ui/views/message_center/web_notification_tray_win.cc (right): https://codereview.chromium.org/14192025/diff/1/chrome/browser/ui/views/message_center/web_notification_tray_win.cc#newcode86 chrome/browser/ui/views/message_center/web_notification_tray_win.cc:86: return *rb.GetImageSkiaNamed(IDR_NOTIFICATION_TRAY_DIM); On 2013/04/19 19:00:50, Jun Mukai wrote: > ...
7 years, 8 months ago (2013-04-19 22:10:28 UTC) #5
Jun Mukai
lgtm
7 years, 8 months ago (2013-04-19 22:11:59 UTC) #6
dewittj
7 years, 8 months ago (2013-04-19 22:21:20 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 manually as r195314 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698