Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 1419173007: [turbofan] Add support for transitioning stores to double fields. (Closed)

Created:
5 years, 1 month ago by Benedikt Meurer
Modified:
5 years, 1 month ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Add support for transitioning stores to double fields. This introduces an AllocateMutableHeapNumberStub for the boxed double field case, where we need to allocate a box in case of a transitioning store first. We cannot use our inline allocations for this currently, because mutable HeapNumber objects have certain alignment constraints, and I don't want to mess up Allocate/AllocateInNewSpace eagerly. Also refactor the PropertyAccessInfoFactory slightly to split the long methods into simpler parts. R=jarin@chromium.org BUG=v8:4470 LOG=n Committed: https://crrev.com/17a651917ae2aa54335dc76d6bcf69d1d86711ec Cr-Commit-Position: refs/heads/master@{#31695}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+191 lines, -61 lines) Patch
M src/code-factory.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/code-factory.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/code-stubs.h View 2 chunks +12 lines, -0 lines 0 comments Download
M src/code-stubs.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M src/compiler/access-builder.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/access-builder.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M src/compiler/js-native-context-specialization.cc View 4 chunks +47 lines, -12 lines 0 comments Download
M src/compiler/property-access-info.h View 2 chunks +8 lines, -0 lines 0 comments Download
M src/compiler/property-access-info.cc View 7 chunks +61 lines, -49 lines 0 comments Download
M src/interface-descriptors.h View 2 chunks +8 lines, -0 lines 0 comments Download
M src/interface-descriptors.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/transitions.h View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 1 month ago (2015-10-30 14:37:25 UTC) #1
Benedikt Meurer
Hey Jaro, Here's the last missing piece for transitioning field stores. Also please appreciate the ...
5 years, 1 month ago (2015-10-30 14:38:34 UTC) #2
Jarin
nice (well, at least the bits I understand look nice :-)). lgtm.
5 years, 1 month ago (2015-10-30 15:01:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1419173007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1419173007/1
5 years, 1 month ago (2015-10-30 15:02:56 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-30 16:11:59 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-10-30 16:12:24 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/17a651917ae2aa54335dc76d6bcf69d1d86711ec
Cr-Commit-Position: refs/heads/master@{#31695}

Powered by Google App Engine
This is Rietveld 408576698