Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 1419173006: Subzero: Use explicit paths to PNaCl tools invoked in szbuild.py. (Closed)

Created:
5 years, 1 month ago by Jim Stichnoth
Modified:
5 years, 1 month ago
Reviewers:
Karl, sehr, John
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero: Use explicit paths to PNaCl tools invoked in szbuild.py. This makes it easier to copy the commands and run them manually. BUG= none R=kschimpf@google.com Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=a2efb9d06c3528203ecdfefece15f567b121117f

Patch Set 1 #

Patch Set 2 : Remove extra newline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -16 lines) Patch
M pydir/szbuild.py View 1 5 chunks +11 lines, -16 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Jim Stichnoth
5 years, 1 month ago (2015-10-30 05:17:22 UTC) #3
Karl
lgtm
5 years, 1 month ago (2015-10-30 15:21:20 UTC) #4
Jim Stichnoth
5 years, 1 month ago (2015-10-30 19:02:48 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
a2efb9d06c3528203ecdfefece15f567b121117f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698