Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 1419143007: Fix bug in CSSOM window.scroll api (Closed)

Created:
5 years, 1 month ago by ymalik
Modified:
5 years, 1 month ago
Reviewers:
bokan
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use inert-visual-viewport flag correctly. With the inert-visual-viewport flag set, window.scrollBy and window.scrollTo should only scroll the layout viewport. Found a logic error where we don't check this flag before calculating current offset. This CL also updates the visual viewport to only fire scroll event when the inert-visual-viewport flag is off. BUG=489206 Committed: https://crrev.com/b4aaa1da24bbd70c05694837a110a45147fa5c16 Cr-Commit-Position: refs/heads/master@{#357887}

Patch Set 1 #

Patch Set 2 : inert scroll events for visual viewport #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -6 lines) Patch
M third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp View 3 chunks +7 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/frame/VisualViewport.cpp View 1 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
ymalik
5 years, 1 month ago (2015-11-04 19:17:10 UTC) #3
bokan
lgtm
5 years, 1 month ago (2015-11-04 19:30:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1419143007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1419143007/20001
5 years, 1 month ago (2015-11-04 20:32:51 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-04 20:37:59 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-04 20:39:01 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b4aaa1da24bbd70c05694837a110a45147fa5c16
Cr-Commit-Position: refs/heads/master@{#357887}

Powered by Google App Engine
This is Rietveld 408576698