Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 1419143003: Show builtin name when printing Code objects. (Closed)

Created:
5 years, 2 months ago by Camillo Bruni
Modified:
5 years, 2 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Show builtin name when printing Code objects. BUG= Committed: https://crrev.com/1c50fc1162c7f5a869bdb9bcf3c04625b40e3e99 Cr-Commit-Position: refs/heads/master@{#31500}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M src/objects.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Camillo Bruni
PTAL
5 years, 2 months ago (2015-10-23 08:16:16 UTC) #2
Yang
On 2015/10/23 08:16:16, cbruni wrote: > PTAL lgtm.
5 years, 2 months ago (2015-10-23 08:26:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1419143003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1419143003/1
5 years, 2 months ago (2015-10-23 08:56:50 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-23 09:19:06 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-23 09:19:52 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1c50fc1162c7f5a869bdb9bcf3c04625b40e3e99
Cr-Commit-Position: refs/heads/master@{#31500}

Powered by Google App Engine
This is Rietveld 408576698