chrome/browser/ui/browser_navigator_params.h - Issue 1419103010: Aura on Android: Compile extensions gn target.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser_navigator_params.h

Issue 1419103010: Aura on Android: Compile extensions gn target. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@compile_extensions_browser

Patch Set: Addressed feedback from patchset 9. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/browser_navigator_params.h

diff --git a/chrome/browser/ui/browser_navigator_params.h b/chrome/browser/ui/browser_navigator_params.h

index d011c0eb986de499fd4bbafe4abd69549d91e2f7..cfc8104bd068e88cb7dcbbd2b08df417dd265daf 100644

--- a/chrome/browser/ui/browser_navigator_params.h

+++ b/chrome/browser/ui/browser_navigator_params.h

@@ -55,7 +55,8 @@ namespace chrome {

struct NavigateParams {

#if defined(OS_ANDROID)

explicit NavigateParams(content::WebContents* a_target_contents);

-#else

+#endif

+#if !defined(OS_ANDROID) || defined(USE_AURA)

NavigateParams(Browser* browser,

const GURL& a_url,

ui::PageTransition a_transition);

@@ -205,7 +206,7 @@ struct NavigateParams {

// Default is IGNORE.

RefBehavior ref_behavior;

-#if !defined(OS_ANDROID)

+#if !defined(OS_ANDROID) || defined(USE_AURA)

// [in] Specifies a Browser object where the navigation could occur or the

// tab could be added. Navigate() is not obliged to use this Browser if

// it is not compatible with the operation being performed. This can be

« no previous file with comments | « chrome/browser/extensions/component_loader.cc ('k') | chrome/browser/ui/browser_navigator_params.cc » ('j') | no next file with comments »