Aura on Android: Compile extensions gn target.

build/config/features.gni

Index: build/config/features.gni
diff --git a/build/config/features.gni b/build/config/features.gni
index c31c7cb6eba7bd617d9e227674313dbc6295b8ad..4500ef7b947891fb42af6073b82a75bf97b44fa8 100644
--- a/build/config/features.gni
+++ b/build/config/features.gni
@@ -24,7 +24,11 @@ declare_args() {
   # Multicast DNS.
   enable_mdns = is_win || is_linux
 
-  enable_plugins = (!is_android && !is_ios) || is_chromecast
+  # We enable plugins on android if use_aura has been explicitly set to true.
+  # use_aura is assigned a value in ui.gni, so it will be undefined here unless

[brettw, 2015/11/12 18:56:27]

The fact that build args are set globally is a bug I'd like to fix. The global
build args should only be set after the corresponding thing is in a declare_args
block. So please don't write code that depends on this behavior.

We could move stuff around to express this nicely. But it doesn't follow to me
that if I enable aura on Android that I get plugins support. These seems sort of
independent, it just so happens that you're only bothering to implement plugins
on aura. So maybe just leave aura out of the defaults and have people explicitly
enable plugins on android if they want them.

If we do that you should note in the comment that it's supported on Android only
in aura.

[Hadi, 2015/11/17 16:49:58]

Removed the changes to features.gni per internal discussion. Planning to address
this change and similar changes to build config in a separate CL.

+  # it was explicitly provided in the build arguments.
+  enable_plugins = (!is_android && !is_ios) || is_chromecast ||
+                   (defined(use_aura) && use_aura)
   enable_pdf = !is_android && !is_ios && !is_chromecast
 
   # Enables Native Client support.