Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Side by Side Diff: build/config/features.gni

Issue 1419103010: Aura on Android: Compile extensions gn target. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@compile_extensions_browser
Patch Set: Addressed feedback. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/app/generated_resources.grd » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # This file contains Chrome-feature-related build flags (see ui.gni for 5 # This file contains Chrome-feature-related build flags (see ui.gni for
6 # UI-related ones). These should theoretically be moved to the build files of 6 # UI-related ones). These should theoretically be moved to the build files of
7 # the features themselves. 7 # the features themselves.
8 # 8 #
9 # However, today we have many "bad" dependencies on some of these flags from, 9 # However, today we have many "bad" dependencies on some of these flags from,
10 # e.g. base, so they need to be global to match the GYP configuration. Also, 10 # e.g. base, so they need to be global to match the GYP configuration. Also,
11 # anything that needs a grit define must be in either this file or ui.gni. 11 # anything that needs a grit define must be in either this file or ui.gni.
12 # 12 #
13 # PLEASE TRY TO AVOID ADDING FLAGS TO THIS FILE in cases where grit isn't 13 # PLEASE TRY TO AVOID ADDING FLAGS TO THIS FILE in cases where grit isn't
14 # required. See the declare_args block of BUILDCONFIG.gn for advice on how 14 # required. See the declare_args block of BUILDCONFIG.gn for advice on how
15 # to set up feature flags. 15 # to set up feature flags.
16 16
17 import("//build/config/chrome_build.gni") 17 import("//build/config/chrome_build.gni")
18 import("//build/config/chromecast_build.gni") 18 import("//build/config/chromecast_build.gni")
19 if (is_android) { 19 if (is_android) {
20 import("//build/config/android/config.gni") 20 import("//build/config/android/config.gni")
21 } 21 }
22 22
23 declare_args() { 23 declare_args() {
24 # Multicast DNS. 24 # Multicast DNS.
25 enable_mdns = is_win || is_linux 25 enable_mdns = is_win || is_linux
26 26
27 enable_plugins = (!is_android && !is_ios) || is_chromecast 27 enable_plugins = is_mac || is_chromecast || (defined(use_aura) && use_aura)
mfomitchev 2015/11/12 16:55:22 The is_mac simplification doesn't work when use_au
Hadi 2015/11/12 17:34:03 Yeah, this change was causing some trybots to fail
28 enable_pdf = !is_android && !is_ios && !is_chromecast 28 enable_pdf = !is_android && !is_ios && !is_chromecast
29 29
30 # Enables Native Client support. 30 # Enables Native Client support.
31 # TODO(GYP): Get NaCl linking on other platforms. 31 # TODO(GYP): Get NaCl linking on other platforms.
32 # Also, see if we can always get rid of enable_nacl_untrusted and 32 # Also, see if we can always get rid of enable_nacl_untrusted and
33 # enable_pnacl and always build them if enable_nacl is true. 33 # enable_pnacl and always build them if enable_nacl is true.
34 # The "is_nacl" part of the condition is needed to ensure that 34 # The "is_nacl" part of the condition is needed to ensure that
35 # the untrusted code is built properly; arguably it should be 35 # the untrusted code is built properly; arguably it should be
36 # guarded by "is_nacl" directly rather than enable_nacl_untrusted, but 36 # guarded by "is_nacl" directly rather than enable_nacl_untrusted, but
37 # this will go away when Mac and Win are working and we can just use 37 # this will go away when Mac and Win are working and we can just use
(...skipping 157 matching lines...) Expand 10 before | Expand all | Expand 10 after
195 # Option controlling the use of GConf (the classic GNOME configuration 195 # Option controlling the use of GConf (the classic GNOME configuration
196 # system). 196 # system).
197 use_gconf = is_linux && !is_chromeos && !is_chromecast 197 use_gconf = is_linux && !is_chromeos && !is_chromecast
198 198
199 # Whether to back up data before sync. 199 # Whether to back up data before sync.
200 enable_pre_sync_backup = is_win || is_mac || (is_linux && !is_chromeos) 200 enable_pre_sync_backup = is_win || is_mac || (is_linux && !is_chromeos)
201 201
202 # Enable WebVR support by default on Android 202 # Enable WebVR support by default on Android
203 # Still requires command line flag to access API 203 # Still requires command line flag to access API
204 enable_webvr = is_android 204 enable_webvr = is_android
OLDNEW
« no previous file with comments | « no previous file | chrome/app/generated_resources.grd » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698