Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 1419103007: Raw 24 bit RGB to RGB24 (bgr) (Closed)

Created:
5 years, 1 month ago by fbarchard1
Modified:
5 years, 1 month ago
Reviewers:
harryjin, fbarchard, xhwang
CC:
harryjin
Base URL:
https://chromium.googlesource.com/libyuv/libyuv@master
Target Ref:
refs/heads/master
Project:
libyuv
Visibility:
Public.

Description

Raw 24 bit RGB to RGB24 (bgr) Add unittests that do 1 step conversion vs 2 step conversion. Tests end swapping versions match direct conversions. R=harryjin@google.com BUG=libyuv:518 Committed: https://chromium.googlesource.com/libyuv/libyuv/+/ce4c2fad1d71f6e4bed20e3a7e518397a44a7e04

Patch Set 1 #

Patch Set 2 : gcc version of rawtorgb24 #

Patch Set 3 : st3 for neon 24 bit stores #

Unified diffs Side-by-side diffs Delta from patch set Stats (+220 lines, -7 lines) Patch
M include/libyuv/planar_functions.h View 1 chunk +8 lines, -0 lines 0 comments Download
M include/libyuv/row.h View 6 chunks +7 lines, -0 lines 0 comments Download
M source/planar_functions.cc View 1 chunk +50 lines, -0 lines 0 comments Download
M source/row_any.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M source/row_common.cc View 1 chunk +14 lines, -0 lines 0 comments Download
M source/row_gcc.cc View 1 2 chunks +48 lines, -0 lines 0 comments Download
M source/row_neon.cc View 1 2 1 chunk +19 lines, -1 line 0 comments Download
M source/row_neon64.cc View 1 2 1 chunk +19 lines, -0 lines 0 comments Download
M source/row_win.cc View 1 3 chunks +46 lines, -5 lines 0 comments Download
M unit_test/convert_test.cc View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
fbarchard
RAWToRGB24 - end swap RGB 24 bit. Allows 2 step conversions and tests.
5 years, 1 month ago (2015-11-03 02:07:24 UTC) #2
fbarchard
SSSE3 version is about same speed as RAWToARGB [ OK ] LibYUVConvertTest.RAWToARGB_Opt (242 ms) [ ...
5 years, 1 month ago (2015-11-03 02:08:28 UTC) #3
fbarchard
ARMv7 version [ OK ] LibYUVConvertTest.RAWToRGB24_Any (1285 ms) [ OK ] LibYUVConvertTest.RAWToRGB24_Opt (1150 ms) [ ...
5 years, 1 month ago (2015-11-03 02:23:28 UTC) #4
fbarchard
aarch64 version [ OK ] LibYUVConvertTest.RAWToRGB24_Any (1188 ms) [ OK ] LibYUVConvertTest.RAWToRGB24_Unaligned (1185 ms) [ ...
5 years, 1 month ago (2015-11-03 02:27:40 UTC) #5
harryjin
lgtm
5 years, 1 month ago (2015-11-03 07:57:21 UTC) #7
fbarchard1
5 years, 1 month ago (2015-11-03 18:30:34 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
ce4c2fad1d71f6e4bed20e3a7e518397a44a7e04 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698