Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 1419103004: nanobench: fix and simplify --samplingTime (Closed)

Created:
5 years, 1 month ago by mtklein_C
Modified:
5 years, 1 month ago
Reviewers:
bsalomon
CC:
reviews_skia.org, Chris Dalton
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

nanobench: fix and simplify --samplingTime Recent changes to WallTimer broke --samplingTime. In particular, this idiom became nonsensical: WallTimer timer; timer.start(); do { ... timer.end(); } while(timer.fWall < ...); WallTimer started making private use of fWall between when start() and end() were called, so the second time around the loop we end up with nonsense. If that makes no sense, don't worry. The code here using now_ms() is just as fast, just as precise, and clearer. I took the opportunity to simplify --samplingTime <complicated string parsing> to --ms <int>, and to simplify the code that depends on it. BUG=skia: Committed: https://skia.googlesource.com/skia/+/bbba16878f343b232d844281fbdf056c00e20fb6

Patch Set 1 #

Patch Set 2 : fmt #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -47 lines) Patch
M bench/nanobench.cpp View 1 9 chunks +17 lines, -47 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1419103004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1419103004/20001
5 years, 1 month ago (2015-10-28 17:58:32 UTC) #3
mtklein_C
5 years, 1 month ago (2015-10-28 18:01:34 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-10-28 18:17:46 UTC) #7
bsalomon
On 2015/10/28 18:01:34, mtklein_C wrote: lgtm
5 years, 1 month ago (2015-10-28 18:26:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1419103004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1419103004/20001
5 years, 1 month ago (2015-10-28 18:35:54 UTC) #10
commit-bot: I haz the power
5 years, 1 month ago (2015-10-28 18:36:32 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/bbba16878f343b232d844281fbdf056c00e20fb6

Powered by Google App Engine
This is Rietveld 408576698