Permissions: browser/ side implementation of multiple permissions request.

Permissions: browser/ side implementation of multiple permissions request.

This is getting multiple permissions request to the browser layer and
implements the backend in the chrome/ layer. This allows multiple
permissions request to be functional on Desktop platforms. On Android,
some other changes are required.

This CL was originally written by lalitm@google.com in:
https://codereview.chromium.org/1316863010
This is a rebased and revisited version of it.

BUG=516626
Committed: https://crrev.com/8b5ec90025b44f12d8f297f1b897b3bbd42baf2d
Cr-Commit-Position: refs/heads/master@{#355942}

[mlamouri (slow - plz ping), 2015-10-22 21:35:27]

mlamouri@chromium.org changed reviewers:
+ jochen@chromium.org, lcwu@chromium.org, torne@chromium.org

[mlamouri (slow - plz ping), 2015-10-22 21:35:28]

Could you PTAL at:
jochen:
  content/public/browser/permission_manager.h
  content/shell/browser/layout_test/layout_test_permission_manager.cc
  content/shell/browser/layout_test/layout_test_permission_manager.h
  content/shell/browser/shell_permission_manager.cc
  content/shell/browser/shell_permission_manager.h
  chrome/browser/permissions/
  content/browser/permissions/
lcwu:
  chromecast/browser/cast_permission_manager.cc
  chromecast/browser/cast_permission_manager.h
torne:
  android_webview/browser/aw_permission_manager.cc
  android_webview/browser/aw_permission_manager.h

Thanks! :)

[Torne, 2015-10-23 10:40:51]

Is this not being implemented in webview tracked anywhere? Are there any callers
of this codepath that previously would have requested permissions one by one
(and therefore succeeded)?

[jochen (gone - plz use gerrit), 2015-10-23 12:06:33]

lgtm

[mlamouri (slow - plz ping), 2015-10-23 13:47:48]

On 2015/10/23 at 10:40:51, torne wrote:
> Is this not being implemented in webview tracked anywhere?

No. Do you want me to file a bug?

> Are there any callers of this codepath that previously would have requested
permissions one by one (and therefore succeeded)?

No. There are currently no callers. The only known future callers will be
navigator.permissions.requestAll();

[Torne, 2015-10-23 14:00:33]

On 2015/10/23 13:47:48, Mounir Lamouri wrote:
> On 2015/10/23 at 10:40:51, torne wrote:
> > Is this not being implemented in webview tracked anywhere?
> 
> No. Do you want me to file a bug?

We have a couple of open bugs about limitations of the permission stuff in
webview already; could just add a note to one of those mentioning that this also
needs to be sorted out.

> > Are there any callers of this codepath that previously would have requested
> permissions one by one (and therefore succeeded)?
> 
> No. There are currently no callers. The only known future callers will be
> navigator.permissions.requestAll();

The permissions API is disabled in webview still, right? If so then we should be
okay here, since we should sort out all the webview permission problems together
before re-enabling it.

LGTM.

[lcwu1, 2015-10-23 17:06:05]

//chromecast lgtm

[mlamouri (slow - plz ping), 2015-10-23 23:29:50]

The CQ bit was checked by mlamouri@chromium.org

[commit-bot: I haz the power, 2015-10-23 23:30:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1419083002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1419083002/1

[commit-bot: I haz the power, 2015-10-24 00:52:11]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-10-24 00:54:37]

Patchset 1 (id:??) landed as
https://crrev.com/8b5ec90025b44f12d8f297f1b897b3bbd42baf2d
Cr-Commit-Position: refs/heads/master@{#355942}