Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1419073005: Finish removing AccountManagerDelegate.Callback. (Closed)

Created:
5 years, 1 month ago by maxbogue
Modified:
5 years, 1 month ago
Reviewers:
knn
CC:
chromium-reviews, tim+watch_chromium.org, pvalenzuela+watch_chromium.org, maxbogue+watch_chromium.org, plaree+watch_chromium.org, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Finish removing AccountManagerDelegate.Callback. This was left in http://crrev.com/1421343002 to prevent downstream from breaking, but downstream has now been converted. BUG=547973 Committed: https://crrev.com/9c1e60d7258b5f72e0899252b5f9fd23aa5a16dc Cr-Commit-Position: refs/heads/master@{#357121}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -38 lines) Patch
M sync/android/java/src/org/chromium/sync/signin/AccountManagerDelegate.java View 2 chunks +4 lines, -12 lines 0 comments Download
M sync/android/java/src/org/chromium/sync/signin/SystemAccountManagerDelegate.java View 4 chunks +4 lines, -20 lines 0 comments Download
M sync/test/android/javatests/src/org/chromium/sync/test/util/MockAccountManager.java View 3 chunks +4 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
maxbogue
Hey Khannan, PTAL!
5 years, 1 month ago (2015-10-30 16:22:24 UTC) #2
knn
On 2015/10/30 16:22:24, maxbogue wrote: > Hey Khannan, PTAL! lgtm.
5 years, 1 month ago (2015-10-30 16:27:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1419073005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1419073005/1
5 years, 1 month ago (2015-10-30 16:29:48 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-30 16:36:12 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-10-30 16:37:03 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/9c1e60d7258b5f72e0899252b5f9fd23aa5a16dc
Cr-Commit-Position: refs/heads/master@{#357121}

Powered by Google App Engine
This is Rietveld 408576698