Displaying "simplify page" on print preview by default

chrome/browser/ui/webui/print_preview/print_preview_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/print_preview/print_preview_handler.h"
 
 #include <ctype.h>
 
 #include <map>
 #include <string>
@@ skipping 1274 matching lines @@
         prefs->GetString(prefs::kPrintPreviewDefaultDestinationSelectionRules);
     if (!rules_str.empty())
       initial_settings.SetString(kDefaultDestinationSelectionRules, rules_str);
   }
 
   if (print_preview_ui()->source_is_modifiable())
     GetNumberFormatAndMeasurementSystem(&initial_settings);
   web_ui()->CallJavascriptFunction("setInitialSettings", initial_settings);
 
   WebContents* initiator = GetInitiator();
-  if (initiator && cmdline->HasSwitch(switches::kEnableDomDistiller) &&
+  if (initiator &&
+      !(cmdline->HasSwitch(switches::kDisablePrintPreviewSimplify)) &&

[Lei Zhang, 2015/10/29 19:14:57]

nit: Too many parenthesis. Just !cmdline->Foo() &&

You can also break this code up a bit more:

if (!cmdline->HasSwitch(switches::kDisablePrintPreviewSimplify))
  return;

WebContents* initiator = GetInitiator();
if (initiator &&
    dom_distiller::url_utils::IsUrlDistillable(
        initiator->GetLastCommittedURL())) {
  web_ui()->CallJavascriptFunction("allowDistillPage");
}

[mvendramini_hp, 2015/10/30 11:05:36]

Done.

       dom_distiller::url_utils::IsUrlDistillable(
           initiator->GetLastCommittedURL())) {
-    dom_distiller::IsDistillablePage(
-        initiator, false,
-        base::Bind(&PrintPreviewHandler::HandleIsPageDistillableResult,
-                   weak_factory_.GetWeakPtr()));
+    web_ui()->CallJavascriptFunction("allowDistillPage");
   }
 }
 
-void PrintPreviewHandler::HandleIsPageDistillableResult(bool distillable) {
-  VLOG(1) << "Distillable page detection finished";
-  if (distillable)
-    web_ui()->CallJavascriptFunction("detectDistillablePage");
-}
-
 void PrintPreviewHandler::ClosePreviewDialog() {
   print_preview_ui()->OnClosePrintPreviewDialog();
 }
 
 void PrintPreviewHandler::SendAccessToken(const std::string& type,
                                           const std::string& access_token) {
   VLOG(1) << "Get getAccessToken finished";
   web_ui()->CallJavascriptFunction("onDidGetAccessToken",
                                    base::StringValue(type),
                                    base::StringValue(access_token));
@@ skipping 495 matching lines @@
 
 void PrintPreviewHandler::UnregisterForGaiaCookieChanges() {
   if (gaia_cookie_manager_service_)
     gaia_cookie_manager_service_->RemoveObserver(this);
 }
 
 void PrintPreviewHandler::SetPdfSavedClosureForTesting(
     const base::Closure& closure) {
   pdf_file_saved_closure_ = closure;
 }