Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6097)

Unified Diff: chrome/browser/resources/settings/reset_page/reset_profile_dialog.js

Issue 1419053008: MD Settings: Construct reset profile dialog only when needed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@reset_ui2
Patch Set: rebase Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/reset_page/reset_profile_dialog.js
diff --git a/chrome/browser/resources/settings/reset_page/reset_page.js b/chrome/browser/resources/settings/reset_page/reset_profile_dialog.js
similarity index 71%
copy from chrome/browser/resources/settings/reset_page/reset_page.js
copy to chrome/browser/resources/settings/reset_page/reset_profile_dialog.js
index 5e57cb0f51f8f74fae9f2cd45480b996cc0abe47..3fe767de5af1a5cb5605148a7bd4c60e7821e0ea 100644
--- a/chrome/browser/resources/settings/reset_page/reset_page.js
+++ b/chrome/browser/resources/settings/reset_page/reset_profile_dialog.js
@@ -4,22 +4,14 @@
/**
* @fileoverview
- * 'settings-reset-page' is the settings page containing reset
+ * 'settings-reset-profile-dialog' is the dialog shown for clearing profile
* settings.
*
- * Example:
- *
- * <iron-animated-pages>
- * <settings-reset-page prefs="{{prefs}}">
- * </settings-reset-page>
- * ... other pages ...
- * </iron-animated-pages>
- *
* @group Chrome Settings Elements
- * @element settings-reset-page
+ * @element settings-reset-profile-dialog
*/
Polymer({
- is: 'settings-reset-page',
+ is: 'settings-reset-profile-dialog',
properties: {
feedbackInfo_: String,
@@ -30,28 +22,27 @@ Polymer({
return {
doneResetting: function() {
this.$.resetSpinner.active = false;
- this.$.resetDialog.close();
+ this.$.dialog.close();
}.bind(this),
setFeedbackInfo: function(data) {
this.set('feedbackInfo_', data.feedbackInfo);
this.async(function() {
- this.$.resetDialog.center();
+ this.$.dialog.center();
});
}.bind(this),
};
}.bind(this));
},
- /** @private */
- onShowDialog_: function() {
- this.$.resetDialog.open();
+ open: function() {
+ this.$.dialog.open();
chrome.send('onShowResetProfileDialog');
},
/** @private */
onCancelTap_: function() {
- this.$.resetDialog.close();
+ this.$.dialog.close();
chrome.send('onHideResetProfileDialog');
},
@@ -71,6 +62,6 @@ Polymer({
// TODO(dpapad): Update how settings info is surfaced when final mocks
// exist.
this.$.settings.hidden = !this.$.sendSettings.checked;
- this.$.resetDialog.center();
- }
+ this.$.dialog.center();
+ },
});

Powered by Google App Engine
This is Rietveld 408576698