chrome/browser/resources/settings/languages_page/languages_page.html - Issue 1419033008: Extract language settings methods into a LanguageHelper interface

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/languages_page/languages_page.html

Issue 1419033008: Extract language settings methods into a LanguageHelper interface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@LanguagePage5InputMethodsAPI

Patch Set: nit Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/languages_page/languages.js ('k') | chrome/browser/resources/settings/languages_page/languages_page.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/languages_page/languages_page.html

diff --git a/chrome/browser/resources/settings/languages_page/languages_page.html b/chrome/browser/resources/settings/languages_page/languages_page.html

index 38fd7aa26f11779073da5aab8ebc8fea32619374..2c703cfee8f9ecf1d2e6df7bd675bc07e591275c 100644

--- a/chrome/browser/resources/settings/languages_page/languages_page.html

+++ b/chrome/browser/resources/settings/languages_page/languages_page.html

@@ -23,8 +23,7 @@

href="chrome://md-settings/settings_page/settings_page.css">

- <settings-languages id="languages" languages="{{languages}}">

- </settings-languages>

+ <settings-languages languages="{{languages}}"></settings-languages>

<settings-animated-pages id="pages" current-route="{{currentRoute}}"

section="languages">

<neon-animatable id="main">

@@ -37,9 +36,11 @@

<paper-item class="split" on-tap="onLanguageTap_">

<div class="flex" title="[[item.language.nativeDisplayName]]"

>[[item.language.displayName]]</div>

+<if expr="chromeos or is_win">

<iron-icon icon="done"

- hidden$="[[!isUILanguage_(item.language.code, prefs.intl.app_locale.value)]]">

+ hidden$="[[!isProspectiveUILanguage_(item.language.code, prefs.intl.app_locale.value)]]">

</iron-icon>

+</if>

<paper-icon-button icon="settings"

on-tap="onShowLanguageDetailTap_"></paper-icon-button>

</paper-item>