chrome/browser/resources/settings/settings_resources.grd - Issue 1419033008: Extract language settings methods into a LanguageHelper interface

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/settings_resources.grd

Issue 1419033008: Extract language settings methods into a LanguageHelper interface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@LanguagePage5InputMethodsAPI

Patch Set: 100% less rebase error Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/settings/languages_page/languages_types.js ('K') | « chrome/browser/resources/settings/languages_page/manage_languages_page.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/settings_resources.grd

diff --git a/chrome/browser/resources/settings/settings_resources.grd b/chrome/browser/resources/settings/settings_resources.grd

index 7577f209cafc77fc52420bb39c472afe6183ff6f..1b9388cf20b972bb3eef494473bdd25f73f89c0e 100644

--- a/chrome/browser/resources/settings/settings_resources.grd

+++ b/chrome/browser/resources/settings/settings_resources.grd

@@ -253,7 +253,9 @@

type="chrome_html" />

<structure name="IDR_SETTINGS_LANGUAGES_JS"

file="languages_page/languages.js"

- type="chrome_html" />

+ type="chrome_html"

+ flattenhtml="true"

+ allowexternalscript="true" />

<structure name="IDR_SETTINGS_LANGUAGES_PAGE_CSS"

file="languages_page/languages_page.css"

type="chrome_html" />

@@ -286,7 +288,9 @@

allowexternalscript="true" />

<structure name="IDR_SETTINGS_LANGUAGES_LANGUAGE_DETAIL_PAGE_JS"

file="languages_page/language_detail_page.js"

- type="chrome_html" />

+ type="chrome_html"

+ flattenhtml="true"

+ allowexternalscript="true" />

<structure name="IDR_SETTINGS_LANGUAGES_EDIT_DICTIONARY_PAGE_CSS"

file="languages_page/edit_dictionary_page.css"