Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Unified Diff: chrome/browser/resources/settings/languages_page/language_detail_page.js

Issue 1419033008: Extract language settings methods into a LanguageHelper interface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@LanguagePage5InputMethodsAPI
Patch Set: dbeam fb Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/languages_page/language_detail_page.js
diff --git a/chrome/browser/resources/settings/languages_page/language_detail_page.js b/chrome/browser/resources/settings/languages_page/language_detail_page.js
index b3b9166e8e594fc3cad12b6f7f8bc249d9d58e8e..3401d8c8326e5f450c979ddc0b65928f819833b6 100644
--- a/chrome/browser/resources/settings/languages_page/language_detail_page.js
+++ b/chrome/browser/resources/settings/languages_page/language_detail_page.js
@@ -35,6 +35,9 @@ Polymer({
detail: Object,
},
+ /** @private {LanguageSettingsHelper} */
+ languageHelper_: settings.LanguageHelper.getInstance(),
+
ready: function() {
// In a CrOS multi-user session, the primary user controls the UI language.
if (this.isSecondaryUser_()) {
@@ -59,7 +62,7 @@ Polymer({
* @private
*/
isProspectiveUILanguage_: function(languageCode, prospectiveUILanguage) {
- return languageCode == this.$.languages.getProspectiveUILanguage();
+ return languageCode == this.languageHelper_.getProspectiveUILanguage();
},
/**
@@ -81,7 +84,7 @@ Polymer({
* @private
*/
isTranslateDisabled_: function(languageCode, targetLanguageCode) {
- return this.$.languages.convertLanguageCodeForTranslate(languageCode) ==
+ return this.languageHelper_.convertLanguageCodeForTranslate(languageCode) ==
targetLanguageCode;
},
@@ -140,9 +143,9 @@ Polymer({
*/
onTranslateEnabledChange_: function(e) {
if (e.target.checked)
- this.$.languages.enableTranslateLanguage(this.detail.language.code);
+ this.languageHelper_.enableTranslateLanguage(this.detail.language.code);
else
- this.$.languages.disableTranslateLanguage(this.detail.language.code);
+ this.languageHelper_.disableTranslateLanguage(this.detail.language.code);
},
/**
@@ -152,10 +155,10 @@ Polymer({
*/
onUILanguageChange_: function(e) {
if (e.target.checked) {
- this.$.languages.setUILanguage(this.detail.language.code);
+ this.languageHelper_.setUILanguage(this.detail.language.code);
} else {
// Reset the chosen UI language to the actual UI language.
- this.$.languages.resetUILanguage();
+ this.languageHelper_.resetUILanguage();
}
},

Powered by Google App Engine
This is Rietveld 408576698