Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issue 1419033006: [Cronet] Make UrlResponseInfo constuctor public for testing (Closed)

Created:
5 years, 1 month ago by pauljensen
Modified:
5 years, 1 month ago
Reviewers:
mef
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Cronet] Make UrlResponseInfo constuctor public for testing Also, add a test for the UrlResponseInfo API. R=mef Committed: https://crrev.com/826bb4293eb8e01c5fa6c7fe6d4a44de6e5b5a53 Cr-Commit-Position: refs/heads/master@{#357109}

Patch Set 1 #

Total comments: 6

Patch Set 2 : address nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -2 lines) Patch
M components/cronet/android/api/src/org/chromium/net/UrlResponseInfo.java View 1 2 chunks +15 lines, -2 lines 0 comments Download
A components/cronet/android/test/javatests/src/org/chromium/net/UrlResponseInfoTest.java View 1 chunk +68 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
pauljensen
Misha, PTAL.
5 years, 1 month ago (2015-10-30 15:14:10 UTC) #1
mef
lgtm with nits. https://codereview.chromium.org/1419033006/diff/1/components/cronet/android/api/src/org/chromium/net/UrlResponseInfo.java File components/cronet/android/api/src/org/chromium/net/UrlResponseInfo.java (right): https://codereview.chromium.org/1419033006/diff/1/components/cronet/android/api/src/org/chromium/net/UrlResponseInfo.java#newcode80 components/cronet/android/api/src/org/chromium/net/UrlResponseInfo.java:80: * Creates a {@link UrlResponseInfo} object. ...
5 years, 1 month ago (2015-10-30 15:24:19 UTC) #2
pauljensen
https://codereview.chromium.org/1419033006/diff/1/components/cronet/android/api/src/org/chromium/net/UrlResponseInfo.java File components/cronet/android/api/src/org/chromium/net/UrlResponseInfo.java (right): https://codereview.chromium.org/1419033006/diff/1/components/cronet/android/api/src/org/chromium/net/UrlResponseInfo.java#newcode80 components/cronet/android/api/src/org/chromium/net/UrlResponseInfo.java:80: * Creates a {@link UrlResponseInfo} object. Provied to facilitate ...
5 years, 1 month ago (2015-10-30 15:29:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1419033006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1419033006/20001
5 years, 1 month ago (2015-10-30 15:29:48 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-10-30 15:41:13 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-10-30 15:41:55 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/826bb4293eb8e01c5fa6c7fe6d4a44de6e5b5a53
Cr-Commit-Position: refs/heads/master@{#357109}

Powered by Google App Engine
This is Rietveld 408576698